getUserMedia sandbox should not be revoked when a getUserMedia allowed request is being processed
Created attachment 369788 [details] Patch
Comment on attachment 369788 [details] Patch Attachment 369788 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12188112 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html
Created attachment 369855 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 369891 [details] Patch
Attachment 369891 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebProcess.cpp:1881: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/WebProcess/WebProcess.cpp:1883: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
<rdar://problem/50786818>
Comment on attachment 369891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369891&action=review > Source/WebCore/ChangeLog:11 > + This is done to ensure that, should capture is failing, the UIProcess Nit: s/should capture is failing/should capture failing/ > Source/WebKit/ChangeLog:19 > + Covered by added test by adding a debug assertion that will be hit in case we revoke extensions while a document is capturing. Nit: s/by added test by adding/by added test and by adding/ > Source/WebKit/UIProcess/UserMediaProcessManager.cpp:160 > - process.send(Messages::WebProcess::RevokeUserMediaDeviceSandboxExtensions(params), proxy.page().pageID()); > + process.send(Messages::WebProcess::RevokeUserMediaDeviceSandboxExtensions(params), 0); Why is this change necessary?
Thanks for the review. (In reply to Eric Carlson from comment #7) > Comment on attachment 369891 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369891&action=review > > > Source/WebCore/ChangeLog:11 > > + This is done to ensure that, should capture is failing, the UIProcess > > Nit: s/should capture is failing/should capture failing/ OK > > Source/WebKit/ChangeLog:19 > > + Covered by added test by adding a debug assertion that will be hit in case we revoke extensions while a document is capturing. > > Nit: s/by added test by adding/by added test and by adding/ OK > Source/WebKit/UIProcess/UserMediaProcessManager.cpp:160 > > - process.send(Messages::WebProcess::RevokeUserMediaDeviceSandboxExtensions(params), proxy.page().pageID()); > > + process.send(Messages::WebProcess::RevokeUserMediaDeviceSandboxExtensions(params), 0); > > Why is this change necessary? There is no need to pass a pageID since the target is the WebProcess not the WebPage. Maybe we were passing the pageID at some point as it was a WebPage message. I'll change it for WebProcess::GrantUserMediaDeviceSandboxExtensions as well.
Created attachment 369967 [details] Patch for landing
Attachment 369967 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebProcess.cpp:1881: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/WebProcess/WebProcess.cpp:1883: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 369967 [details] Patch for landing Clearing flags on attachment: 369967 Committed r245335: <https://trac.webkit.org/changeset/245335>
All reviewed patches have been landed. Closing bug.