[JSC] Shrink sizeof(UnlinkedFunctionExecutable) more
Created attachment 369710 [details] Patch
Created attachment 369712 [details] Patch
Comment on attachment 369712 [details] Patch Attachment 369712 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12174771 New failing tests: inspector/debugger/js-stacktrace.html
Created attachment 369721 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369712 [details] Patch Attachment 369712 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12174749 New failing tests: inspector/debugger/js-stacktrace.html
Created attachment 369722 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 369712 [details] Patch Attachment 369712 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12174857 New failing tests: inspector/debugger/js-stacktrace.html
Created attachment 369723 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 369814 [details] Patch
Created attachment 369821 [details] Patch
Nice. It might be worth doing the same to CachedFunctionExecutable so we can also shrink the bytecode cache size (or at least adding a FIXME).
Comment on attachment 369821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369821&action=review > Source/JavaScriptCore/ChangeLog:16 > + 2. We drop m_inferredName and prefer m_ecmaName. The inferred name is used to offer better function name when the function expression lacks > + the name, but now ECMAScript has a specified semantics to name those functions with intuitive names. We should use ecmaName consistently, > + and should not eat 8 bytes for inferred names in UnlinkedFunctionExecutable. Seems like a great strategy, but longer term there has to be something more elegant than calling this "ECMA name".
Comment on attachment 369821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369821&action=review >> Source/JavaScriptCore/ChangeLog:16 >> + and should not eat 8 bytes for inferred names in UnlinkedFunctionExecutable. > > Seems like a great strategy, but longer term there has to be something more elegant than calling this "ECMA name". Right! Currently, we hold m_ecmaName and m_name separately, but I think we could remove m_name side since m_ecmaName should subsume the use case of m_name. Once it is done, we can just call it "m_name".
(In reply to Tadeu Zagallo from comment #11) > Nice. It might be worth doing the same to CachedFunctionExecutable so we can > also shrink the bytecode cache size (or at least adding a FIXME). Nice, done!
Committed r245288: <https://trac.webkit.org/changeset/245288>
<rdar://problem/50772182>
Rebaslined inspector/model/remote-object.html in: https://trac.webkit.org/changeset/245303/webkit After it was broken by https://trac.webkit.org/changeset/245288/webkit
Comment on attachment 369821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369821&action=review > Source/JavaScriptCore/parser/ASTBuilder.h:-1506 > - static_cast<BaseFuncExprNode*>(expr)->metadata()->setInferredName(dot->identifier()); FWIW, this slightly alters the object previews shown in Web Inspector. <http://trac.webkit.org/r245303>