...
<rdar://problem/50530400>
Created attachment 369626 [details] patch
Comment on attachment 369626 [details] patch r=me
Comment on attachment 369626 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369626&action=review > JSTests/stress/js-to-wasm-callee-has-correct-prototype.js:1 > +//@ runDefault("--jitPolicyScale=0", "--useSamplingProfiler=1") Don't we usually put these tests in the wasm directory?
(In reply to Keith Miller from comment #4) > Comment on attachment 369626 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369626&action=review > > > JSTests/stress/js-to-wasm-callee-has-correct-prototype.js:1 > > +//@ runDefault("--jitPolicyScale=0", "--useSamplingProfiler=1") > > Don't we usually put these tests in the wasm directory? Not always. If you grep through stress you will find some Wasm tests.
(In reply to Saam Barati from comment #5) > (In reply to Keith Miller from comment #4) > > Comment on attachment 369626 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=369626&action=review > > > > > JSTests/stress/js-to-wasm-callee-has-correct-prototype.js:1 > > > +//@ runDefault("--jitPolicyScale=0", "--useSamplingProfiler=1") > > > > Don't we usually put these tests in the wasm directory? > > Not always. If you grep through stress you will find some Wasm tests. The reason I put it here is it allowed me to do the `runDefault` at the top. That'd be different if I made it a Wasm test unfortunately.
Comment on attachment 369626 [details] patch Clearing flags on attachment: 369626 Committed r245203: <https://trac.webkit.org/changeset/245203>
All reviewed patches have been landed. Closing bug.