Bug 197801 - A service worker instance should be terminated when its SWServer is destroyed
Summary: A service worker instance should be terminated when its SWServer is destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-10 15:07 PDT by youenn fablet
Modified: 2019-05-13 15:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2019-05-10 15:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-05-10 15:07:10 PDT 
A service worker instance should be terminated when its SWServer is destroyed
Comment 1 youenn fablet 2019-05-10 15:30:21 PDT 
<rdar://problem/50587270>
Comment 2 youenn fablet 2019-05-10 15:33:34 PDT 
Created attachment 369608 [details]
Patch
Comment 3 WebKit Commit Bot 2019-05-10 16:33:44 PDT 
Comment on attachment 369608 [details]
Patch

Clearing flags on attachment: 369608

Committed r245200: <https://trac.webkit.org/changeset/245200>
Comment 4 WebKit Commit Bot 2019-05-10 16:33:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2019-05-13 14:32:09 PDT 
What mechanism prevents two concurrent but independent sessions from sharing a service worker?
Comment 6 Chris Dumez 2019-05-13 15:08:04 PDT 
(In reply to Geoffrey Garen from comment #5)
> What mechanism prevents two concurrent but independent sessions from sharing
> a service worker?

We use a different SWServer instance per session ID. Service worker instances are owned by each SWServer instance so I do not believe different session can share service workers.