Bug 197777 – Add WKWebViewConfiguration._canShowWhileLocked SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Add WKWebViewConfiguration._canShowWhileLocked SPI.

[Chris Dumez]

<rdar://problem/50065100>

[Chris Dumez]

Created attachment 369552 [details]
Patch

[Chris Dumez]

Created attachment 369555 [details]
Patch

[Tim Horton]

Comment on attachment 369555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369555&action=review

> Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> +        kCAContextSecure: canShowWhileLocked ? @YES : @NO,

@(canShowWhileLocked)

> Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> +        kCAContextCIFilterBehavior :  @"ignore",

Pretty sure these are all Mac paths and don’t support this option. But maybe the symbol is there and the extra key will be ignored?

[Tim Horton]

(In reply to Tim Horton from comment #4)
> Comment on attachment 369555 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369555&action=review
> 
> > Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> > +        kCAContextSecure: canShowWhileLocked ? @YES : @NO,
> 
> @(canShowWhileLocked)
> 
> > Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> > +        kCAContextCIFilterBehavior :  @"ignore",
> 
> Pretty sure these are all Mac paths and don’t support this option. But maybe
> the symbol is there and the extra key will be ignored?

To be clear I meant the one you added not the one that got quoted

[Chris Dumez]

Created attachment 369568 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 369568 [details]
Patch

Clearing flags on attachment: 369568

Committed r245183: <https://trac.webkit.org/changeset/245183>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.