Bug 197777 - Add WKWebViewConfiguration._canShowWhileLocked SPI
Summary: Add WKWebViewConfiguration._canShowWhileLocked SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-10 08:57 PDT by Chris Dumez
Modified: 2019-05-10 11:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.36 KB, patch)
2019-05-10 09:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (16.37 KB, patch)
2019-05-10 09:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.67 KB, patch)
2019-05-10 10:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-05-10 08:57:33 PDT 
Add WKWebViewConfiguration._canShowWhileLocked SPI.
Comment 1 Chris Dumez 2019-05-10 08:57:50 PDT 
<rdar://problem/50065100>
Comment 2 Chris Dumez 2019-05-10 09:12:05 PDT 
Created attachment 369552 [details]
Patch
Comment 3 Chris Dumez 2019-05-10 09:38:51 PDT 
Created attachment 369555 [details]
Patch
Comment 4 Tim Horton 2019-05-10 09:45:49 PDT 
Comment on attachment 369555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369555&action=review

> Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> +        kCAContextSecure: canShowWhileLocked ? @YES : @NO,

@(canShowWhileLocked)

> Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> +        kCAContextCIFilterBehavior :  @"ignore",

Pretty sure these are all Mac paths and don’t support this option. But maybe the symbol is there and the extra key will be ignored?
Comment 5 Tim Horton 2019-05-10 09:46:28 PDT 
(In reply to Tim Horton from comment #4)
> Comment on attachment 369555 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369555&action=review
> 
> > Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> > +        kCAContextSecure: canShowWhileLocked ? @YES : @NO,
> 
> @(canShowWhileLocked)
> 
> > Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> > +        kCAContextCIFilterBehavior :  @"ignore",
> 
> Pretty sure these are all Mac paths and don’t support this option. But maybe
> the symbol is there and the extra key will be ignored?

To be clear I meant the one you added not the one that got quoted
Comment 6 Chris Dumez 2019-05-10 10:50:19 PDT 
Created attachment 369568 [details]
Patch
Comment 7 WebKit Commit Bot 2019-05-10 11:52:12 PDT 
Comment on attachment 369568 [details]
Patch

Clearing flags on attachment: 369568

Committed r245183: <https://trac.webkit.org/changeset/245183>
Comment 8 WebKit Commit Bot 2019-05-10 11:52:14 PDT 
All reviewed patches have been landed.  Closing bug.