Bug 197768 - Layer bounds are incorrect for sharing layers that paint with transforms
Summary: Layer bounds are incorrect for sharing layers that paint with transforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 197561
  Show dependency tree / graph
 
Reported: 2019-05-09 22:19 PDT by Simon Fraser (smfr)
Modified: 2019-05-11 15:22 PDT (History)
4 users (show)

See Also:

Attachments
Testcase (792 bytes, text/html)
2019-05-09 22:19 PDT, Simon Fraser (smfr) 		no flags Details
Patch (15.19 KB, patch)
2019-05-11 11:11 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-05-09 22:19:53 PDT 
Created attachment 369545 [details]
Testcase

Attached testcase (with layer borders on) show that we make backing that is much too big when the shared layer has a transform.

We need to do the right transform math when computing composited bounds.
Comment 1 Simon Fraser (smfr) 2019-05-10 22:08:33 PDT 
We're getting localClipRect and transforming it, which seems wrong.
Comment 2 Radar WebKit Bug Importer 2019-05-11 11:09:52 PDT 
<rdar://problem/50695493>
Comment 3 Simon Fraser (smfr) 2019-05-11 11:11:03 PDT 
Created attachment 369654 [details]
Patch
Comment 4 WebKit Commit Bot 2019-05-11 15:22:41 PDT 
Comment on attachment 369654 [details]
Patch

Clearing flags on attachment: 369654

Committed r245208: <https://trac.webkit.org/changeset/245208>
Comment 5 WebKit Commit Bot 2019-05-11 15:22:42 PDT 
All reviewed patches have been landed.  Closing bug.