Bug 197758 - Returning incorrect marked text rects
Summary: Returning incorrect marked text rects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-09 16:41 PDT by Megan Gardner
Modified: 2019-05-10 13:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.73 KB, patch)
2019-05-09 16:43 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (2.73 KB, patch)
2019-05-10 13:37 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-05-09 16:41:50 PDT
Returning incorrect marked text rects
Comment 1 Megan Gardner 2019-05-09 16:43:56 PDT
Created attachment 369529 [details]
Patch
Comment 2 Megan Gardner 2019-05-09 16:44:22 PDT
<rdar://problem/46548586>
Comment 3 Tim Horton 2019-05-09 17:41:08 PDT
Comment on attachment 369529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369529&action=review

> Source/WebKit/ChangeLog:9
> +        We are not returning marked text rects in the correct view coordinant space.

coordinate

> Source/WebKit/ChangeLog:13
> +        (WebKit::WebPage::platformEditorState const):

Where's the test :P
Comment 4 Megan Gardner 2019-05-10 13:37:08 PDT
Created attachment 369593 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-05-10 13:52:38 PDT
Comment on attachment 369593 [details]
Patch for landing

Clearing flags on attachment: 369593

Committed r245195: <https://trac.webkit.org/changeset/245195>
Comment 6 WebKit Commit Bot 2019-05-10 13:52:39 PDT
All reviewed patches have been landed.  Closing bug.