Bug 197753 - [iOS] Numpad comma key has incorrect keyIdentifier property
Summary: [iOS] Numpad comma key has incorrect keyIdentifier property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 190571
  Show dependency tree / graph
 
Reported: 2019-05-09 14:00 PDT by Daniel Bates
Modified: 2019-05-09 15:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.95 KB, patch)
2019-05-09 14:25 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To land (12.82 KB, patch)
2019-05-09 15:59 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-05-09 14:00:37 PDT 
On JIS keyboards they have a Num Pad Comma key. DOM key events dispatched when this key are pressed and released have keyIdentifier property equal to Unidentified instead of Numpad Comma. We should fix this.
Comment 1 Radar WebKit Bug Importer 2019-05-09 14:01:12 PDT 
<rdar://problem/50636274>
Comment 2 Daniel Bates 2019-05-09 14:25:24 PDT 
Created attachment 369521 [details]
Patch
Comment 3 Brent Fulgham 2019-05-09 14:32:03 PDT 
Comment on attachment 369521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369521&action=review

Japanese keyboard users will be very happy! r=me.

> Source/WebCore/ChangeLog:14
> +        ",", which is what.

which is what WHAT! :-)
Comment 4 Daniel Bates 2019-05-09 14:38:43 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 369521 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369521&action=review
> 
> Japanese keyboard users will be very happy! r=me.
> 
> > Source/WebCore/ChangeLog:14
> > +        ",", which is what.
> 
> which is what WHAT! :-)

Haha. What we wanted 😀
Comment 5 Daniel Bates 2019-05-09 15:59:03 PDT 
Created attachment 369528 [details]
To land
Comment 6 Daniel Bates 2019-05-09 15:59:43 PDT 
Committed r245161: <https://trac.webkit.org/changeset/245161>