Remove now-unnecessary Connection::sendMessageWithReply 
https://bugs.webkit.org/show_bug.cgi?id=197747
Summary Remove now-unnecessary Connection::sendMessageWithReply
Alex Christensen
Reported 2019-05-09 11:43:29 PDT
Remove now-unnecessary Connection::sendMessageWithReply
Attachments
Patch (12.29 KB, patch)
2019-05-09 11:47 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (14.91 KB, patch)
2019-05-09 12:05 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-05-09 11:47:18 PDT
Created attachment 369505 [details] Patch
Alex Christensen
Comment 2 2019-05-09 12:05:20 PDT
Created attachment 369509 [details] Patch
Ryan Haddad
Comment 3 2019-05-09 16:07:38 PDT
This change landed in https://trac.webkit.org/changeset/245151/webkit It appears to have caused High Sierra Debug WK2 tests to exit early with assertion failures: ASSERTION FAILED: RunLoop::isMain() /Volumes/Data/slave/highsierra-debug/build/Source/WebKit/Platform/IPC/Connection.cpp(507) : std::unique_ptr<Decoder> IPC::Connection::sendSyncMessage(uint64_t, std::unique_ptr<Encoder>, WTF::Seconds, OptionSet<IPC::SendSyncOption>) 1 0x121703739 WTFCrash 2 0x1074f147b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1075472a1 IPC::Connection::sendSyncMessage(unsigned long long, std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) 4 0x107d8e824 bool IPC::Connection::sendSync<Messages::SecItemShimProxy::SecItemRequest>(Messages::SecItemShimProxy::SecItemRequest&&, Messages::SecItemShimProxy::SecItemRequest::Reply&&, unsigned long long, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) 5 0x107d8e2f6 WebKit::sendSecItemRequest(WebKit::SecItemRequestData::Type, __CFDictionary const*, __CFDictionary const*) 6 0x107d8d98f WebKit::webSecItemCopyMatching(__CFDictionary const*, void const**) 7 0x106dc5eac WebKit::shimSecItemCopyMatching(__CFDictionary const*, void const**) 8 0x7fff53dc3889 StorageQuery::performQuery() 9 0x7fff53dfaed4 PersistentCredentialStorage::copyDefaultCredentialForProtectionSpace(_CFURLProtectionSpace*) 10 0x7fff53dfd470 CFURLCredentialStorageCopyDefaultCredentialForProtectionSpace 11 0x7fff53f24493 -[NSURLCredentialStorage defaultCredentialForProtectionSpace:] 12 0x7fff53f245ad -[NSURLCredentialStorage getDefaultCredentialForProtectionSpace:task:completionHandler:] 13 0x7fff53e3dec1 NSXCredentialStorage::copyDefaultCredentialForProtectionSpace(_CFURLProtectionSpace*, NSURLSessionTask const*) const 14 0x7fff53e7ea53 HTTPProtocol::_CFHTTPProtHasCredentialsForChallenge(__CFHTTPMessage*) 15 0x7fff53e814f7 HTTPProtocol::attemptAuthentication(__CFHTTPMessage*) 16 0x7fff53d81a03 HTTPProtocol::performHeaderRead(__CFHTTPMessage*) 17 0x7fff53d81258 HTTPProtocol::handleStreamEvent(__CFHTTPMessage*, dispatch_data_s*, CFStreamError const*) 18 0x7fff53d68e9b HTTPTransaction::_onqueue_invokeHandler() 19 0x7fff53d6bba5 HTTPConnection::_onqueue_responseDataArrived(dispatch_data_s*, CFStreamError, bool) 20 0x7fff53d6ba73 HTTPEngine::_readBodyFinish(dispatch_data_s*, CFStreamError, bool) 21 0x7fff53d6b937 HTTPEngine::_deliverBodyBytes(dispatch_data_s*, CFStreamError, bool) 22 0x7fff53f40fad invocation function for block in HTTPEngine::_getBodyIntelligently(void (dispatch_data_s*, CFStreamError, bool) block_pointer) 23 0x7fff7cd9e5fa _dispatch_call_block_and_release 24 0x7fff7cd96db8 _dispatch_client_callout 25 0x7fff7cdab217 _dispatch_queue_serial_drain 26 0x7fff7cd9e166 _dispatch_queue_invoke 27 0x7fff7cdab07a _dispatch_queue_serial_drain 28 0x7fff7cd9e166 _dispatch_queue_invoke 29 0x7fff7cdabf0d _dispatch_root_queue_drain_deferred_wlh 30 0x7fff7cdafd21 _dispatch_workloop_worker_thread 31 0x7fff7d0e7fd2 _pthread_wqthread https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r245155%20(7733)/results.html
Chris Dumez
Comment 5 2019-05-30 12:32:06 PDT
Looks like Alex rolled most of this out in http://trac.webkit.org/changeset/245164/webkit.
Note You need to log in before you can comment on or make changes to this bug.