Bug 197738 - pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a timeout
Summary: pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a tim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-09 06:59 PDT by Antoine Quint
Modified: 2019-05-09 07:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.79 KB, patch)
2019-05-09 07:04 PDT, Antoine Quint 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-05-09 06:59:17 PDT 
pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a timeout
Comment 1 Antoine Quint 2019-05-09 07:04:28 PDT 
Created attachment 369490 [details]
Patch
Comment 2 Antoine Quint 2019-05-09 07:04:33 PDT 
<rdar://problem/50588613>
Comment 3 Antti Koivisto 2019-05-09 07:10:47 PDT 
Comment on attachment 369490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369490&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:345
> +        m_activeTouchActions = scrollingCoordinatorProxy.activeTouchActionsForTouchIdentifier(*touchIdentifier);

Should this be cleared when the scrolling fully finishes? Seem bet weird that it can stay non-empty long past the gesture.
Comment 4 Antoine Quint 2019-05-09 07:16:03 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 369490 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369490&action=review
> 
> > Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:345
> > +        m_activeTouchActions = scrollingCoordinatorProxy.activeTouchActionsForTouchIdentifier(*touchIdentifier);
> 
> Should this be cleared when the scrolling fully finishes? Seem bet weird
> that it can stay non-empty long past the gesture.

Fixing this in commit.
Comment 5 Antoine Quint 2019-05-09 07:16:54 PDT 
Committed r245134: <https://trac.webkit.org/changeset/245134>