RESOLVED FIXED 197737
[ews-build] Fix formatting issues and typos 
https://bugs.webkit.org/show_bug.cgi?id=197737
Summary [ews-build] Fix formatting issues and typos
Aakash Jain
Reported 2019-05-09 06:02:31 PDT
Fix formatting issues and typos in ews-build.
Attachments
Patch (2.96 KB, patch)
2019-05-09 06:04 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-05-09 06:04:59 PDT
Created attachment 369488 [details] Patch
Jonathan Bedard
Comment 2 2019-05-09 08:43:51 PDT
Comment on attachment 369488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369488&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/step.py:67 > + _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid)) We're bumping up the logging level here (from 10 to 20), any reason why?
Aakash Jain
Comment 3 2019-05-09 09:04:40 PDT
Comment on attachment 369488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369488&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/step.py:67 >> + _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid)) > > We're bumping up the logging level here (from 10 to 20), any reason why? Yeah, I mentioned in ChangeLog 'Changed log level to info so that it is logged in production'. Also the log level was inconsistent with similar log statement below (_log.info('Updated step {} in database for build: {}')
WebKit Commit Bot
Comment 4 2019-05-09 10:13:52 PDT
Comment on attachment 369488 [details] Patch Clearing flags on attachment: 369488 Committed r245141: <https://trac.webkit.org/changeset/245141>
WebKit Commit Bot
Comment 5 2019-05-09 10:13:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-05-09 10:19:26 PDT
<rdar://problem/50626334>
Note You need to log in before you can comment on or make changes to this bug.