Bug 197737 - [ews-build] Fix formatting issues and typos
Summary: [ews-build] Fix formatting issues and typos
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-09 06:02 PDT by Aakash Jain
Modified: 2019-05-09 10:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.96 KB, patch)
2019-05-09 06:04 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-05-09 06:02:31 PDT
Fix formatting issues and typos in ews-build.
Comment 1 Aakash Jain 2019-05-09 06:04:59 PDT
Created attachment 369488 [details]
Patch
Comment 2 Jonathan Bedard 2019-05-09 08:43:51 PDT
Comment on attachment 369488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369488&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/step.py:67
> +        _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid))

We're bumping up the logging level here (from 10 to 20), any reason why?
Comment 3 Aakash Jain 2019-05-09 09:04:40 PDT
Comment on attachment 369488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369488&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/models/step.py:67
>> +        _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid))
> 
> We're bumping up the logging level here (from 10 to 20), any reason why?

Yeah, I mentioned in ChangeLog 'Changed log level to info so that it is logged in production'. Also the log level was inconsistent with similar log statement below (_log.info('Updated step {} in database for build: {}')
Comment 4 WebKit Commit Bot 2019-05-09 10:13:52 PDT
Comment on attachment 369488 [details]
Patch

Clearing flags on attachment: 369488

Committed r245141: <https://trac.webkit.org/changeset/245141>
Comment 5 WebKit Commit Bot 2019-05-09 10:13:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-05-09 10:19:26 PDT
<rdar://problem/50626334>