Bug 197729 – [ews-app] Add migrations file to repository

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

As per https://docs.djangoproject.com/en/1.11/topics/migrations/ "The migration files for each app live in a “migrations” directory inside of that app, and are designed to be committed to, and distributed as part of, its codebase."

We should add the migration file for ews-app to the repository. That would make it easier to reproduce the environment consistently, and also make it easier to track schema changes.

[Aakash Jain]

Created attachment 369483 [details]
Patch

[EWS Watchlist]

Comment on attachment 369483 [details]
Patch

Attachment 369483 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12142880

New failing tests:
svg/repaint/remove-border-property-on-root.html

[EWS Watchlist]

Created attachment 369486 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Jonathan Bedard]

I agree that committing this is a good idea, but only if we're at a point where the schema is expected to be mostly stable, are we at that point?

To be clear, I'm am expecting future schema changes, but I'm not expecting us to be iterating on the entire architecture of the EWS app.

[Aakash Jain]

(In reply to Jonathan Bedard from comment #4)
> I agree that committing this is a good idea, but only if we're at a point where the schema is expected to be mostly stable, are we at that point?
Yup. I think we are at that point. I have been holding this off for a while for this reason. Haven't had any schema change for over a month.

Also since we have already deployed in production, Django will create separate incremental migration file for any further schema change on the production server. Therefore it's best to check-it in to keep any testing environment similar to production environment.

[WebKit Commit Bot]

Comment on attachment 369483 [details]
Patch

Rejecting attachment 369483 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 369483, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=369483&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=197729&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 369483 from bug 197729.
Fetching: https://bugs.webkit.org/attachment.cgi?id=369483
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	Tools/BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py
	M	Tools/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Tools/ChangeLog' is out of date
W: d1599aa859c669d28e8a4b1fe1dd724bde53a424 and refs/remotes/origin/master differ, using rebase:
:040000 040000 67c82fe09f18f7f7f83091684aa3659ae80602b7 2495a140cb61937660b028a44ba3f51ca3cd6de3 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	Tools/BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py
	M	Tools/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Tools/ChangeLog' is out of date
W: d1599aa859c669d28e8a4b1fe1dd724bde53a424 and refs/remotes/origin/master differ, using rebase:
:040000 040000 67c82fe09f18f7f7f83091684aa3659ae80602b7 2495a140cb61937660b028a44ba3f51ca3cd6de3 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   5878df6af83..1649d903353  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 245139 = 5878df6af83a29d7c9fcbcb966a118c0d13e1b73
r245140 = 1649d90335371087c6c329c46a2a7b0fe3893cf2
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/12144465

[Aakash Jain]

Comment on attachment 369483 [details]
Patch

Clearing flags on attachment: 369483

Committed r245143: <https://trac.webkit.org/changeset/245143>

[Aakash Jain]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50626696>