Bug 197728 - Guard long press link preview with a USE macro rather than complicated includes
Summary: Guard long press link preview with a USE macro rather than complicated includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-08 17:45 PDT by Dean Jackson
Modified: 2019-05-09 12:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.48 KB, patch)
2019-05-08 17:50 PDT, Dean Jackson
wenson_hsieh: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (13.65 MB, application/zip)
2019-05-08 20:51 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-05-08 17:45:38 PDT
Guard long press link preview with a USE macro rather than complicated includes
Comment 1 Radar WebKit Bug Importer 2019-05-08 17:46:15 PDT
<rdar://problem/50604700>
Comment 2 Dean Jackson 2019-05-08 17:50:31 PDT
Created attachment 369452 [details]
Patch
Comment 3 Build Bot 2019-05-08 20:51:07 PDT
Comment on attachment 369452 [details]
Patch

Attachment 369452 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12139527

New failing tests:
editing/selection/doubleclick-crash.html
Comment 4 Build Bot 2019-05-08 20:51:09 PDT
Created attachment 369458 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Dean Jackson 2019-05-09 12:46:53 PDT
Committed r245153: <https://trac.webkit.org/changeset/245153>
Comment 6 Dean Jackson 2019-05-09 12:47:05 PDT
Committed r245153: <https://trac.webkit.org/changeset/245153>