Bug 197710 – Pass insertTextAsync options as a struct

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

WebPageProxy::insertTextAsync() is becoming unwieldy to work with given the large number of optional arguments that can be passed and I am eyeing to pass another optional argument towards fixing bug #197632. Let's pass a struct of options instead.

[Daniel Bates]

Created attachment 369424 [details]
Patch

[Daniel Bates]

Created attachment 369427 [details]
Patch

[Daniel Bates]

Created attachment 369431 [details]
Patch

[Brent Fulgham]

Comment on attachment 369431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369431&action=review

Looks like a nice simplification. r=me.

> Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36
> +    EditingRangeIsRelativeTo editingRangeIsRelativeTo { EditingRangeIsRelativeTo::EditableRoot };

It might be more space-efficient to move the booleans to the bottom of the struct.

[Daniel Bates]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 369431 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369431&action=review
> 
> Looks like a nice simplification. r=me.
> 
> > Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36
> > +    EditingRangeIsRelativeTo editingRangeIsRelativeTo { EditingRangeIsRelativeTo::EditableRoot };
> 
> It might be more space-efficient to move the booleans to the bottom of the
> struct.

It shouldn't make a difference. sizeof(bool) == 1 == sizeof(uint8_t).

[Daniel Bates]

Comment on attachment 369431 [details]
Patch

Clearing flags on attachment: 369431

Committed r245073: <https://trac.webkit.org/changeset/245073>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50600263>