Bug 197700 – [ews-app] Production and Development env should configure DEBUG appropriately

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

[ews-app] Production and Development env should configure DEBUG appropriately in the Django app.

[Radar WebKit Bug Importer]

<rdar://problem/50590650>

[Aakash Jain]

Created attachment 369402 [details]
Patch

[Jonathan Bedard]

Comment on attachment 369402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369402&action=review

> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:36
> +is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None

I usually prefer something like:

not int(os.getenv('EWS_PRODUCTION', 0))

What will the value of EWS_PRODUCTION be? I suppose this is being moved so it doesn't have to change, though.

> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:50
> +    # SECURITY WARNING: don't run with debug turned on in production!

Is it possible to log this somewhere? It doesn't seem useful as a nested comment.

[Aakash Jain]

Comment on attachment 369402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369402&action=review

>> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:36
>> +is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None
> 
> I usually prefer something like:
> 
> not int(os.getenv('EWS_PRODUCTION', 0))
> 
> What will the value of EWS_PRODUCTION be? I suppose this is being moved so it doesn't have to change, though.

EWS_PRODUCTION=true

This is similar to our all other buildbot instance. e.g.: See <rdar://problem/49263590>.

>> Tools/BuildSlaveSupport/ews-app/ews-app/settings.py:50
>> +    # SECURITY WARNING: don't run with debug turned on in production!
> 
> Is it possible to log this somewhere? It doesn't seem useful as a nested comment.

This comment (and file) was autogenerated by Django. I am just moving it around. This patch ensure that we don't turn on debug in production.

[EWS Watchlist]

Comment on attachment 369402 [details]
Patch

Attachment 369402 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12139698

New failing tests:
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 369463 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 369402 [details]
Patch

Clearing flags on attachment: 369402

Committed r245136: <https://trac.webkit.org/changeset/245136>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.