Bug 197699 - Add plumbing for inactive system colors in RenderTheme cache
Summary: Add plumbing for inactive system colors in RenderTheme cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-08 11:51 PDT by Timothy Hatcher
Modified: 2019-05-08 15:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (24.78 KB, patch)
2019-05-08 12:01 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews214 for win-future (13.67 MB, application/zip)
2019-05-08 14:34 PDT, Build Bot
no flags Details
Patch (23.13 KB, patch)
2019-05-08 15:22 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-05-08 11:51:35 PDT
Some system colors that might be different when the view/window is inactive. We can't cache them in the same cache or the result will be wrong for subsequent cache accesses.

<rdar://problem/49406936>
Comment 1 Timothy Hatcher 2019-05-08 12:01:48 PDT Comment hidden (obsolete)
Comment 2 Tim Horton 2019-05-08 13:57:39 PDT
Comment on attachment 369403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369403&action=review

> Source/WebKit/ChangeLog:40
> +2019-05-08  Timothy Hatcher  <timothy@apple.com>
> +
> +        Add plumbing for inactive system colors for RenderTheme cache.
> +        https://bugs.webkit.org/show_bug.cgi?id=197699
> +

Double changelog
Comment 3 Build Bot 2019-05-08 14:34:43 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2019-05-08 14:34:45 PDT Comment hidden (obsolete)
Comment 5 Timothy Hatcher 2019-05-08 15:22:08 PDT
Created attachment 369433 [details]
Patch
Comment 6 Timothy Hatcher 2019-05-08 15:25:30 PDT
Committed r245072. https://trac.webkit.org/changeset/245072/webkit