Bug 197699 – Add plumbing for inactive system colors in RenderTheme cache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Timothy Hatcher]

Some system colors that might be different when the view/window is inactive. We can't cache them in the same cache or the result will be wrong for subsequent cache accesses.

<rdar://problem/49406936>

[Timothy Hatcher]

Created attachment 369403 [details]
Patch

[Tim Horton]

Comment on attachment 369403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369403&action=review

> Source/WebKit/ChangeLog:40
> [phone]  Timothy Hatcher  <[e-mail]>
> +
> +        Add plumbing for inactive system colors for RenderTheme cache.
> +        https://bugs.webkit.org/show_bug.cgi?id=197699
> +

Double changelog

[EWS Watchlist]

Comment on attachment 369403 [details]
Patch

Attachment 369403 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12136282

New failing tests:
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 369423 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Timothy Hatcher]

Created attachment 369433 [details]
Patch

[Timothy Hatcher]

Committed r245072. https://trac.webkit.org/changeset/245072/webkit