If a layer gets backing-shared that has a transform, the rendering is incorrect. Affects http://www.deeplearningbook.org/contents/intro.html
<rdar://problem/50652127>
Created attachment 369544 [details] Patch
Created attachment 369561 [details] WIP
Created attachment 369637 [details] Patch
Comment on attachment 369637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369637&action=review > LayoutTests/compositing/shared-backing/shared-layer-has-transform-expected.html:31 > + .trigger { > + transform: translateZ(0); I imagine we might optimimize this case some day to not composite so this might not be the safest trigger.
(In reply to Antti Koivisto from comment #5) > Comment on attachment 369637 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369637&action=review > > > LayoutTests/compositing/shared-backing/shared-layer-has-transform-expected.html:31 > > + .trigger { > > + transform: translateZ(0); > > I imagine we might optimimize this case some day to not composite so this > might not be the safest trigger. When that happens we'll have to change a lot of tests :)
Comment on attachment 369637 [details] Patch Attachment 369637 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12160154 New failing tests: compositing/shared-backing/shared-transformed-layer-bounds.html compositing/shared-backing/sharing-layer-has-effect.html compositing/shared-backing/sharing-layer-becomes-non-scrollable.html
Created attachment 369638 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Added a couple of test files by mistake. Why is mac-wk2 green?
Created attachment 369639 [details] Patch
Comment on attachment 369637 [details] Patch Attachment 369637 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12160202 New failing tests: compositing/shared-backing/shared-transformed-layer-bounds.html compositing/shared-backing/sharing-layer-has-effect.html compositing/shared-backing/sharing-layer-becomes-non-scrollable.html
Created attachment 369641 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369637 [details] Patch Attachment 369637 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12160230 New failing tests: compositing/shared-backing/shared-transformed-layer-bounds.html compositing/shared-backing/sharing-layer-has-effect.html compositing/shared-backing/sharing-layer-becomes-non-scrollable.html
Created attachment 369642 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 369639 [details] Patch Attachment 369639 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12160567 New failing tests: compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html compositing/shared-backing/shared-layer-bounds.html
Created attachment 369643 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369639 [details] Patch Attachment 369639 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12160593 New failing tests: compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll.html compositing/shared-backing/overflow-scroll/shared-layer-repaint.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html compositing/shared-backing/shared-layer-bounds.html
Created attachment 369644 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 369639 [details] Patch Attachment 369639 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12160695 New failing tests: imported/blink/compositing/squashing/squash-overflow-hidden-contents.html
Created attachment 369645 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 369639 [details] Patch Attachment 369639 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12160617 New failing tests: compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/shared-backing/shared-layer-bounds.html
Created attachment 369646 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 369639 [details] Patch Attachment 369639 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12160643 New failing tests: compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll.html compositing/shared-backing/overflow-scroll/shared-layer-repaint.html compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html compositing/shared-backing/shared-layer-bounds.html
Created attachment 369647 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Created attachment 369652 [details] Patch
*** Bug 197783 has been marked as a duplicate of this bug. ***
Comment on attachment 369652 [details] Patch Clearing flags on attachment: 369652 Committed r245205: <https://trac.webkit.org/changeset/245205>