Bug 197686 – iOS: Selection is dismissed even if click is preventDefault()'d

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

iOS: Selection is dismissed even if click is preventDefault()'d

[Tim Horton]

Created attachment 369363 [details]
Patch

[Tim Horton]

<rdar://problem/49398824>

[EWS Watchlist]

Comment on attachment 369363 [details]
Patch

Attachment 369363 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12131254

New failing tests:
editing/pasteboard/smart-paste-paragraph-003.html
editing/deleting/smart-delete-paragraph-003.html

[EWS Watchlist]

Created attachment 369366 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

[Tim Horton]

Created attachment 369371 [details]
Patch

[EWS Watchlist]

Comment on attachment 369371 [details]
Patch

Attachment 369371 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12132257

New failing tests:
svg/repaint/remove-border-property-on-root.html

[EWS Watchlist]

Created attachment 369374 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[EWS Watchlist]

Comment on attachment 369371 [details]
Patch

Attachment 369371 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12132434

New failing tests:
editing/pasteboard/smart-paste-paragraph-003.html
editing/deleting/smart-delete-paragraph-003.html

[EWS Watchlist]

Created attachment 369380 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

[Tim Horton]

Created attachment 369397 [details]
Patch

[Wenson Hsieh]

Comment on attachment 369397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369397&action=review

> LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler-expected.txt:3
> +This test verifies that the WebCore selection is not dismissed when tapping on an element that preventDefault()s the click event.

Nit - perhaps s/WebCore/DOM/?

[Antoine Quint]

Comment on attachment 369397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369397&action=review

> LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler.html:38
> +        document.addEventListener("selectionchange", didChangeSelection);

Maybe use { once: true } here to avoid the cleanup?

[Tim Horton]

Comment on attachment 369397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369397&action=review

>> LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler-expected.txt:3
>> +This test verifies that the WebCore selection is not dismissed when tapping on an element that preventDefault()s the click event.
> 
> Nit - perhaps s/WebCore/DOM/?

Sure

>> LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler.html:38
>> +        document.addEventListener("selectionchange", didChangeSelection);
> 
> Maybe use { once: true } here to avoid the cleanup?

😲

[Tim Horton]

(In reply to Tim Horton from comment #13)
> Comment on attachment 369397 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369397&action=review
> 
> >> LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler-expected.txt:3
> >> +This test verifies that the WebCore selection is not dismissed when tapping on an element that preventDefault()s the click event.
> > 
> > Nit - perhaps s/WebCore/DOM/?
> 
> Sure
> 
> >> LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler.html:38
> >> +        document.addEventListener("selectionchange", didChangeSelection);
> > 
> > Maybe use { once: true } here to avoid the cleanup?
> 
> 😲

Wait, no.

[Tim Horton]

Created attachment 369401 [details]
Patch

[Tim Horton]

Created attachment 369412 [details]
Patch

[Tim Horton]

Created attachment 369415 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 369415 [details]
Patch

Clearing flags on attachment: 369415

Committed r245067: <https://trac.webkit.org/changeset/245067>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

My rebaselines might not quite have been right. Will try again

[Ryan Haddad]

(In reply to Tim Horton from comment #20)
> My rebaselines might not quite have been right. Will try again
For posterity, this was the second attempt: https://trac.webkit.org/changeset/245077/webkit