Bug 197677 – macro assembler code-pointer tagging has its arguments backwards

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Keith Miller]

Normally, we have the macro assembler code put the destination as the right-most parameter. the code-pointer tagging has the destination on the left.

[Saam Barati]

*** Bug 197422 has been marked as a duplicate of this bug. ***

[Saam Barati]

Created attachment 369765 [details]
patch

[Michael Saboff]

Comment on attachment 369765 [details]
patch

r=me, but it looks like you need to fix mips.

[Saam Barati]

Created attachment 369769 [details]
patch for landing

[Tadeu Zagallo]

Comment on attachment 369769 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=369769&action=review

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:980
>      ALWAYS_INLINE void tagPtr(RegisterID, PtrTag) { }

Shouldn't this be flipped as well?

[Saam Barati]

Comment on attachment 369769 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=369769&action=review

>> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:980
>>      ALWAYS_INLINE void tagPtr(RegisterID, PtrTag) { }
> 
> Shouldn't this be flipped as well?

yup

[Saam Barati]

Created attachment 369779 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 369779 [details]
patch for landing

Clearing flags on attachment: 369779

Committed r245251: <https://trac.webkit.org/changeset/245251>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50739261>