Bug 197672 - WTF::TimingScope should show the total duration and not just the mean
Summary: WTF::TimingScope should show the total duration and not just the mean
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-07 12:57 PDT by Robin Morisset
Modified: 2019-05-08 11:19 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2019-05-07 12:59 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (13.63 MB, application/zip)
2019-05-07 19:58 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-05-07 12:57:39 PDT 
I found myself frequently multiplying the mean duration by the number of calls to find the total time spent in a function. It is trivial to just have TimingScope show this information.
Comment 1 Robin Morisset 2019-05-07 12:59:02 PDT 
Created attachment 369317 [details]
Patch

trivial patch.
Comment 2 EWS Watchlist 2019-05-07 19:58:24 PDT 
Comment on attachment 369317 [details]
Patch

Attachment 369317 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12129493

New failing tests:
http/tests/css/filters-on-iframes.html
Comment 3 EWS Watchlist 2019-05-07 19:58:26 PDT 
Created attachment 369352 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Robin Morisset 2019-05-08 10:52:11 PDT 
Comment on attachment 369317 [details]
Patch

The windows bot appears red in general, it is not related to this patch.
Comment 5 WebKit Commit Bot 2019-05-08 11:18:47 PDT 
Comment on attachment 369317 [details]
Patch

Clearing flags on attachment: 369317

Committed r245061: <https://trac.webkit.org/changeset/245061>
Comment 6 WebKit Commit Bot 2019-05-08 11:18:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-08 11:19:26 PDT 
<rdar://problem/50588584>