Bug 197665 – [Pointer Events] isPrimary property of pointercancel events should match previous events for that pointer

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Antoine Quint]

[Pointer Events] isPrimary property of pointercancel events should match previous events for that pointer

[Antoine Quint]

Created attachment 369296 [details]
Patch

[Dean Jackson]

Comment on attachment 369296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369296&action=review

> Source/WebCore/dom/PointerEvent.h:55
> +    enum class IsPrimary : uint8_t { No, Yes };

Do we normally name these bool-like enums isFoo?

[WebKit Commit Bot]

Comment on attachment 369296 [details]
Patch

Clearing flags on attachment: 369296

Committed r245020: <https://trac.webkit.org/changeset/245020>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50548910>

[Antoine Quint]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 369296 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369296&action=review
> 
> > Source/WebCore/dom/PointerEvent.h:55
> > +    enum class IsPrimary : uint8_t { No, Yes };
> 
> Do we normally name these bool-like enums isFoo?

I think so. This was fashioned to match these from WebCore/dom/Event.h:

    enum class IsTrusted : uint8_t { No, Yes };
    enum class IsCancelable : uint8_t { No, Yes };
    enum class IsComposed : uint8_t { No, Yes };

[Chris Dumez]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 369296 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369296&action=review
> 
> > Source/WebCore/dom/PointerEvent.h:55
> > +    enum class IsPrimary : uint8_t { No, Yes };
> 
> Do we normally name these bool-like enums isFoo?

I personally like ": bool" better for things that are clearly booleans.