Bug 197639 - REGRESSION (r244900): Layout Test media/track/track-cue-missing.html is failing on iOS and macOS debug
Summary: REGRESSION (r244900): Layout Test media/track/track-cue-missing.html is faili...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-06 16:45 PDT by Ryan Haddad
Modified: 2019-05-07 11:44 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2019-05-06 16:45:15 PDT
The following layout test is failing on iOS and macOS debug bots

media/track/track-cue-missing.html

Probable cause:

The dashboard suggests this regression range: https://trac.webkit.org/log/webkit/?verbose=on&rev=244901&stop_rev=244900

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-cue-missing.html

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/media/track/track-cue-missing-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/media/track/track-cue-missing-actual.txt
@@ -5,6 +5,6 @@
 EVENT(loadeddata)
 Created 121 cues.
 EVENT(ended)
-EXPECTED (missedCueCount < '50') OK
+EXPECTED (missedCueCount < '50'), OBSERVED '72' FAIL
 END OF TEST
Comment 1 Ryan Haddad 2019-05-06 16:45:28 PDT
I have not yet been able to reproduce this locally.
Comment 2 Ryan Haddad 2019-05-06 17:02:30 PDT
Using the following command, I cannot reproduce this with a debug build of r244899, but I can with r244900:

run-webkit-tests media/track/track-cue-missing.html --no-retry --iter 10 --exit-after-n-failures 1
Comment 3 Ryan Haddad 2019-05-06 17:03:20 PDT
Simon, could you please take a look at this?
Comment 4 Simon Fraser (smfr) 2019-05-06 17:08:39 PDT
It seems like the code that runs for logging just made the test slower, so it's a bad test.
Comment 5 Simon Fraser (smfr) 2019-05-06 17:09:41 PDT
Presumably it's only bad in debug. Let's just mark it flakey for debug only.
Comment 6 Alexey Proskuryakov 2019-05-06 21:51:00 PDT
The plan is to roll back the patch, not to increase the number of tests marked as flaky.
Comment 7 Ryan Haddad 2019-05-07 11:43:23 PDT
Rolled out r244900 in https://trac.webkit.org/r245019
Comment 8 Radar WebKit Bug Importer 2019-05-07 11:44:17 PDT
<rdar://problem/50548909>