RESOLVED FIXED 197619
Temporarily disable generate-xcfilelists 
https://bugs.webkit.org/show_bug.cgi?id=197619
Summary Temporarily disable generate-xcfilelists
Keith Rollin
Reported 2019-05-06 12:01:41 PDT
We need to perform a significant update to the generate-xcfilelist scripts. This work involves coordinated work with another facility. If the work does not occur in tandem, the build will be broken. To avoid this, disable the invoking of the scripts during the transition. The checking will be restored once the new scripts are in place.
Attachments
Patch (7.60 KB, patch)
2019-05-06 12:06 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews210 for win-future (13.69 MB, application/zip)
2019-05-06 14:02 PDT, EWS Watchlist 		no flags
Details
Patch (8.04 KB, patch)
2019-05-06 15:34 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-06 12:02:37 PDT
<rdar://problem/50507392>
Keith Rollin
Comment 2 2019-05-06 12:06:50 PDT
Created attachment 369154 [details] Patch
EWS Watchlist
Comment 3 2019-05-06 14:02:25 PDT
Comment on attachment 369154 [details] Patch Attachment 369154 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12114795 New failing tests: js/dom/custom-constructors.html
EWS Watchlist
Comment 4 2019-05-06 14:02:29 PDT
Created attachment 369168 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Keith Rollin
Comment 5 2019-05-06 14:11:55 PDT
My change does not affect Windows builds, so that failure is not mine. Also: > Unable to pass tests without patch (tree is red?) [results]
Alex Christensen
Comment 6 2019-05-06 14:36:27 PDT
Comment on attachment 369154 [details] Patch I think these ought to have a comment: # FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=?????? is resolved
Keith Rollin
Comment 7 2019-05-06 15:34:47 PDT
Added comment.
Keith Rollin
Comment 8 2019-05-06 15:34:56 PDT
Created attachment 369181 [details] Patch
WebKit Commit Bot
Comment 9 2019-05-06 16:13:54 PDT
Comment on attachment 369181 [details] Patch Clearing flags on attachment: 369181 Committed r244987: <https://trac.webkit.org/changeset/244987>
WebKit Commit Bot
Comment 10 2019-05-06 16:13:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.