Bug 197619 - Temporarily disable generate-xcfilelists
Summary: Temporarily disable generate-xcfilelists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-06 12:01 PDT by Keith Rollin
Modified: 2019-05-06 16:46 PDT (History)
13 users (show)

See Also:


Attachments
Patch (7.60 KB, patch)
2019-05-06 12:06 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (13.69 MB, application/zip)
2019-05-06 14:02 PDT, Build Bot
no flags Details
Patch (8.04 KB, patch)
2019-05-06 15:34 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-05-06 12:01:41 PDT
We need to perform a significant update to the generate-xcfilelist scripts. This work involves coordinated work with another facility. If the work does not occur in tandem, the build will be broken. To avoid this, disable the invoking of the scripts during the transition. The checking will be restored once the new scripts are in place.
Comment 1 Radar WebKit Bug Importer 2019-05-06 12:02:37 PDT
<rdar://problem/50507392>
Comment 2 Keith Rollin 2019-05-06 12:06:50 PDT
Created attachment 369154 [details]
Patch
Comment 3 Build Bot 2019-05-06 14:02:25 PDT
Comment on attachment 369154 [details]
Patch

Attachment 369154 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12114795

New failing tests:
js/dom/custom-constructors.html
Comment 4 Build Bot 2019-05-06 14:02:29 PDT
Created attachment 369168 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Keith Rollin 2019-05-06 14:11:55 PDT
My change does not affect Windows builds, so that failure is not mine. Also:

> Unable to pass tests without patch (tree is red?) [results]
Comment 6 Alex Christensen 2019-05-06 14:36:27 PDT
Comment on attachment 369154 [details]
Patch

I think these ought to have a comment:
# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=?????? is resolved
Comment 7 Keith Rollin 2019-05-06 15:34:47 PDT
Added comment.
Comment 8 Keith Rollin 2019-05-06 15:34:56 PDT
Created attachment 369181 [details]
Patch
Comment 9 WebKit Commit Bot 2019-05-06 16:13:54 PDT
Comment on attachment 369181 [details]
Patch

Clearing flags on attachment: 369181

Committed r244987: <https://trac.webkit.org/changeset/244987>
Comment 10 WebKit Commit Bot 2019-05-06 16:13:56 PDT
All reviewed patches have been landed.  Closing bug.