Bug 197615 – [PlayStation] JSC Stress tests failing due to timezone printing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Stephan Szabo]

PlayStation's strftime's "%Z" returns an empty string which results in time strings like "Wed Oct 23 1974 11:45:01 GMT-0700" rather than "Wed Oct 23 1974 11:45:01 GMT-0700 (Pacific Daylight Time)" which causes diff failures with the expectations.

[Stephan Szabo]

Created attachment 369126 [details]
Patch

Adding expectations without the timezone string for these tests on PlayStation.

ChakraCore/test/GlobalFunctions/InternalToString.js
ChakraCore/test/Operators/equals.js
ChakraCore/test/fieldopts/objtypespec-newobj.2.js

The timezone names are being managed in the tests to do PDT/PST to full name conversions, so we could strip them instead, but that seemed like it could lose information useful to test on the other platforms.

[Ross Kirsling]

Comment on attachment 369126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369126&action=review

> JSTests/ChakraCore.yaml:693
> +          runChakra :baseline, "NoException", "InternalToString.playstation.baseline", []

The bare .baseline files are as-is from ChakraCore, so we should mark this .baseline-jsc.
I can't seem to find a precedent for a platform-specific baseline though -- maybe .baseline-jsc-playstation, so that we keep the more specific stuff at the very end?

[Stephan Szabo]

Created attachment 369137 [details]
Patch

Changing names per review comment.

[WebKit Commit Bot]

Comment on attachment 369137 [details]
Patch

Clearing flags on attachment: 369137

Committed r244972: <https://trac.webkit.org/changeset/244972>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50510575>