Bug 197605 – JS2 should print scores for different categories

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 369101 [details]
patch

[Tadeu Zagallo]

Why is this only for the CLI? Also, the ChangeLog entry is missing.

[Yusuke Suzuki]

Comment on attachment 369101 [details]
patch

r=me. As Tadeu said, adding this feature to non-cli version would be also useful too (yeah, it would involve some UI changes...
And please add ChangeLog for this.

[Saam Barati]

(In reply to Tadeu Zagallo from comment #2)
> Why is this only for the CLI? Also, the ChangeLog entry is missing.

If we add it to the website, we should do it behind some kind of key click when we're done running. Let me look into it.

[Saam Barati]

Created attachment 369153 [details]
patch

[Yusuke Suzuki]

Comment on attachment 369153 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review

r=me

> PerformanceTests/JetStream2/JetStreamDriver.js:53
> +    for (let [category, scores] of categoryScores)
> +        summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>`

I think sorting the categories is better.

> PerformanceTests/JetStream2/JetStreamDriver.js:247
> +            for (let [category, scores] of categoryScores)
> +                console.log(`${category}: ${uiFriendlyNumber(geomean(scores))}`);

Ditto.

[Saam Barati]

Comment on attachment 369153 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review

>> PerformanceTests/JetStream2/JetStreamDriver.js:53
>> +        summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>`
> 
> I think sorting the categories is better.

How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other.

[Yusuke Suzuki]

Comment on attachment 369153 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review

>>> PerformanceTests/JetStream2/JetStreamDriver.js:53
>>> +        summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>`
>> 
>> I think sorting the categories is better.
> 
> How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other.

OK, talked with Saam. The order is kept by ES6 Map.

[WebKit Commit Bot]

Comment on attachment 369153 [details]
patch

Clearing flags on attachment: 369153

Committed r244973: <https://trac.webkit.org/changeset/244973>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50511028>