Bug 197593 - fast/attachment/attachment-folder-icon.html is an Image Only failure on recent macOS builds
Summary: fast/attachment/attachment-folder-icon.html is an Image Only failure on recen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-04 16:47 PDT by Wenson Hsieh
Modified: 2019-05-05 13:38 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2019-05-04 16:56 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (13.59 MB, application/zip)
2019-05-04 20:56 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-05-04 16:47:14 PDT
<rdar://problem/50379267>
Comment 1 Wenson Hsieh 2019-05-04 16:56:18 PDT
Created attachment 369075 [details]
Patch
Comment 2 Build Bot 2019-05-04 20:56:55 PDT Comment hidden (obsolete)
Comment 3 Build Bot 2019-05-04 20:56:57 PDT Comment hidden (obsolete)
Comment 4 Tim Horton 2019-05-05 03:18:57 PDT
Comment on attachment 369075 [details]
Patch

Do we need the same change in RenderThemeIOS?
Comment 5 WebKit Commit Bot 2019-05-05 03:45:27 PDT
Comment on attachment 369075 [details]
Patch

Clearing flags on attachment: 369075

Committed r244956: <https://trac.webkit.org/changeset/244956>
Comment 6 WebKit Commit Bot 2019-05-05 03:45:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Wenson Hsieh 2019-05-05 13:38:47 PDT
(In reply to Tim Horton from comment #4)
> Comment on attachment 369075 [details]
> Patch
> 
> Do we need the same change in RenderThemeIOS?

I don't believe we do, since this logic to convert these MIME types to a UTI for an icon only exists on macOS.

That being said, there is another issue that needs to be addressed, which is that currently, dropping or pasting folders on both macOS and iOS using the new attachments SPI will create attachments with type "public.directory" instead of "public.folder".

I plan to fix this separately.