Bug 197586 - iOS JSC tests frequently exiting with exception after stress/json-stringify-string-builder-overflow.js.no-cjit-validate-phases
Summary: iOS JSC tests frequently exiting with exception after stress/json-stringify-s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-03 16:18 PDT by Michael Saboff
Modified: 2019-05-03 19:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2019-05-03 16:22 PDT, Michael Saboff
keith_miller: review+
keith_miller: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2019-05-03 16:18:55 PDT
This test uses lots of memory.  We should restrict where we run it and if we do run it, e don't need to run all configurations.
Comment 1 Michael Saboff 2019-05-03 16:19:09 PDT
<rdar://problem/50458665>
Comment 2 Michael Saboff 2019-05-03 16:22:34 PDT
Created attachment 369015 [details]
Patch
Comment 3 Keith Miller 2019-05-03 16:27:14 PDT
Comment on attachment 369015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369015&action=review

r=me with change.

> JSTests/stress/json-stringify-string-builder-overflow.js:4
>  //@ skip if $architecture != "arm64" and $architecture != "x86-64"

Can we remove this line since it doesn't do anything.
Comment 4 Michael Saboff 2019-05-03 16:31:47 PDT
(In reply to Keith Miller from comment #3)
> Comment on attachment 369015 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369015&action=review
> 
> r=me with change.
> 
> > JSTests/stress/json-stringify-string-builder-overflow.js:4
> >  //@ skip if $architecture != "arm64" and $architecture != "x86-64"
> 
> Can we remove this line since it doesn't do anything.

I'll move this above the //@ lines I added.
Comment 5 Michael Saboff 2019-05-03 16:34:54 PDT
Committed r244937: <https://trac.webkit.org/changeset/244937>