Bug 197584 - [JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
Summary: [JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-03 16:02 PDT by Yusuke Suzuki
Modified: 2019-05-03 16:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.59 KB, patch)
2019-05-03 16:19 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (7.45 KB, patch)
2019-05-03 16:21 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-05-03 16:02:44 PDT 
[JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
Comment 1 Yusuke Suzuki 2019-05-03 16:19:26 PDT 
Created attachment 369013 [details]
Patch
Comment 2 Yusuke Suzuki 2019-05-03 16:21:48 PDT 
Created attachment 369014 [details]
Patch
Comment 3 Yusuke Suzuki 2019-05-03 16:31:15 PDT 
<rdar://problem/50435721>
Comment 4 Saam Barati 2019-05-03 16:46:37 PDT 
Comment on attachment 369014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369014&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack

This seems weird.
Comment 5 Saam Barati 2019-05-03 16:47:38 PDT 
(In reply to Saam Barati from comment #4)
> Comment on attachment 369014 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369014&action=review
> 
> > Source/JavaScriptCore/ChangeLog:10
> > +        and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack
> 
> This seems weird.

Actually I guess it makes sense. I wonder if we can remove this requirement at some point
Comment 6 Yusuke Suzuki 2019-05-03 16:51:04 PDT 
Comment on attachment 369014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369014&action=review

Thanks!

>>> Source/JavaScriptCore/ChangeLog:10
>>> +        and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack
>> 
>> This seems weird.
> 
> Actually I guess it makes sense. I wonder if we can remove this requirement at some point

Yeah, we should eventually remove this requirement...
Comment 7 Yusuke Suzuki 2019-05-03 16:57:32 PDT 
Committed r244939: <https://trac.webkit.org/changeset/244939>