Bug 197583 - [CMake] fuse-ld should also be set in module linker flags
Summary: [CMake] fuse-ld should also be set in module linker flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-03 15:27 PDT by Christopher Reid
Modified: 2019-05-06 00:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.14 KB, patch)
2019-05-03 16:45 PDT, Christopher Reid
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (13.76 MB, application/zip)
2019-05-03 23:59 PDT, Build Bot
no flags Details
Patch for landing (1.84 KB, patch)
2019-05-06 00:27 PDT, Christopher Reid
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2019-05-03 15:27:54 PDT
I hit an odd linker error when trying to turn on CFI in GTK.
-fuse-ld=lld wasn't being set when linking the libWebProcessTest.so module.
Comment 1 Christopher Reid 2019-05-03 16:45:46 PDT
Created attachment 369021 [details]
Patch
Comment 2 Christopher Reid 2019-05-03 23:50:19 PDT
Hm it looks like the GTK build is failing now because --no-undefined was being overwritten when CMAKE_SHARED_LINKER_FLAGS is set to CMAKE_EXE_LINKER_FLAG.
I'll take that change out for now.
Comment 3 Build Bot 2019-05-03 23:59:43 PDT
Comment on attachment 369021 [details]
Patch

Attachment 369021 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12097236

New failing tests:
http/tests/css/filters-on-iframes.html
Comment 4 Build Bot 2019-05-03 23:59:46 PDT
Created attachment 369062 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Christopher Reid 2019-05-06 00:27:21 PDT
Created attachment 369108 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-05-06 00:54:34 PDT
Comment on attachment 369108 [details]
Patch for landing

Clearing flags on attachment: 369108

Committed r244960: <https://trac.webkit.org/changeset/244960>
Comment 7 WebKit Commit Bot 2019-05-06 00:54:35 PDT
All reviewed patches have been landed.  Closing bug.