Bug 197581 - Adopt AVStreamDataParser.audiovisualMIMETypes
Summary: Adopt AVStreamDataParser.audiovisualMIMETypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-03 15:12 PDT by Jer Noble
Modified: 2019-05-06 15:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (41.32 KB, patch)
2019-05-03 15:31 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (47.36 KB, patch)
2019-05-06 11:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (47.42 KB, patch)
2019-05-06 12:36 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-05-03 15:12:33 PDT 
Adopt AVStreamDataParser.audiovisualMIMETypes
Comment 1 Radar WebKit Bug Importer 2019-05-03 15:12:58 PDT 
<rdar://problem/50458981>
Comment 2 Jer Noble 2019-05-03 15:31:03 PDT 
Created attachment 369005 [details]
Patch
Comment 3 Eric Carlson 2019-05-03 16:11:43 PDT 
Comment on attachment 369005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369005&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:77
> +    // AVStreamDataParser does not have an -isPlayableExtendedMIMEType: method, so just replace the container type
> +    // with a valid one from AVAssetMIMETypeCache and ask that cache if it can decode this type:

You should add a FIXME to remove this once they implement -isPlayableExtendedMIMEType

> Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:81
> +    ContentType originalType { mimeType };

Can't you just reuse "type" defined above?
Comment 4 Jer Noble 2019-05-06 10:34:13 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 369005 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369005&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:77
> > +    // AVStreamDataParser does not have an -isPlayableExtendedMIMEType: method, so just replace the container type
> > +    // with a valid one from AVAssetMIMETypeCache and ask that cache if it can decode this type:
> 
> You should add a FIXME to remove this once they implement
> -isPlayableExtendedMIMEType

Will do.

> > Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:81
> > +    ContentType originalType { mimeType };
> 
> Can't you just reuse "type" defined above?

Yep!
Comment 5 Jer Noble 2019-05-06 11:08:48 PDT 
Created attachment 369142 [details]
Patch for landing
Comment 6 Jer Noble 2019-05-06 12:36:24 PDT 
Created attachment 369157 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-05-06 15:22:32 PDT 
Comment on attachment 369157 [details]
Patch for landing

Clearing flags on attachment: 369157

Committed r244980: <https://trac.webkit.org/changeset/244980>
Comment 8 WebKit Commit Bot 2019-05-06 15:22:33 PDT 
All reviewed patches have been landed.  Closing bug.