Bug 197577 - AVFoundation framework isn't always installed
Summary: AVFoundation framework isn't always installed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-03 14:15 PDT by Eric Carlson
Modified: 2019-05-03 14:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.02 KB, patch)
2019-05-03 14:20 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-05-03 14:15:21 PDT 
r244704 broke the AVFoundation availability checks.
Comment 1 Eric Carlson 2019-05-03 14:15:37 PDT 
<rdar://problem/50447841>
Comment 2 Eric Carlson 2019-05-03 14:20:54 PDT 
Created attachment 368988 [details]
Patch
Comment 3 Jer Noble 2019-05-03 14:22:58 PDT 
Comment on attachment 368988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368988&action=review

r=me.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:229
> -    return PAL::AVFoundationLibrary() && isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();
> +    return isAVFoundationFrameworkAvailable() && isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();

Why no PAL?
Comment 4 Eric Carlson 2019-05-03 14:27:10 PDT 
(In reply to Jer Noble from comment #3)
> Comment on attachment 368988 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368988&action=review
> 
> r=me.
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:229
> > -    return PAL::AVFoundationLibrary() && isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();
> > +    return isAVFoundationFrameworkAvailable() && isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();
> 
> Why no PAL?

It won't compile because that file has a "using namespace PAL"
Comment 5 Jer Noble 2019-05-03 14:30:48 PDT 
(In reply to Eric Carlson from comment #4)
> (In reply to Jer Noble from comment #3)
> > Comment on attachment 368988 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=368988&action=review
> > 
> > r=me.
> > 
> > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:229
> > > -    return PAL::AVFoundationLibrary() && isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();
> > > +    return isAVFoundationFrameworkAvailable() && isCoreMediaFrameworkAvailable() && getAVSampleBufferDisplayLayerClass();
> > 
> > Why no PAL?
> 
> It won't compile because that file has a "using namespace PAL"

👍🏻
Comment 6 WebKit Commit Bot 2019-05-03 14:47:42 PDT 
Comment on attachment 368988 [details]
Patch

Clearing flags on attachment: 368988

Committed r244922: <https://trac.webkit.org/changeset/244922>
Comment 7 WebKit Commit Bot 2019-05-03 14:47:44 PDT 
All reviewed patches have been landed.  Closing bug.