Bug 197573 – [iOS] outlook.live.com: Compose email frame not fully visible and not scrollable

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://problem/48008441>

[Radar WebKit Bug Importer]

<rdar://problem/50454671>

[zalan]

(In reply to Radar WebKit Bug Importer from comment #1)
> <rdar://problem/50454671>
well thank you very much.

[zalan]

Created attachment 369000 [details]
Patch

[Brent Fulgham]

Comment on attachment 369000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369000&action=review

> Source/WebCore/page/Quirks.cpp:73
> +#if PLATFORM(IOS_FAMILY)

I don't think we need to restrict this to iOS -- you can totally hit this by putting the web view Into the right size.

[zalan]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 369000 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369000&action=review
> 
> > Source/WebCore/page/Quirks.cpp:73
> > +#if PLATFORM(IOS_FAMILY)
> 
> I don't think we need to restrict this to iOS -- you can totally hit this by
> putting the web view Into the right size.
yeah, though the viewportconfig concept is iOS only atm.

[zalan]

Created attachment 369017 [details]
Patch

[Wenson Hsieh]

Comment on attachment 369017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369017&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2885
> +    viewportChanged |= m_viewportConfiguration.setViewLayoutSize(adjustedViewLayoutSize(viewLayoutSize));

Nit - I have a slight preference for a more explicit name that makes it clear that this is only here to support hard-coded site-specific layout width quirks, and shouldn't be used for more general purposes. How about something like viewLayoutSizeAdjustedForQuirks?

[zalan]

Created attachment 369034 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 369034 [details]
Patch

Clearing flags on attachment: 369034

Committed r244944: <https://trac.webkit.org/changeset/244944>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.