Bug 197543 - [WebAuthN] A focused document should be required
Summary: [WebAuthN] A focused document should be required
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2019-05-02 18:49 PDT by Jiewen Tan
Modified: 2019-05-03 16:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.26 KB, patch)
2019-05-02 19:03 PDT, Jiewen Tan
bfulgham: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.62 MB, application/zip)
2019-05-02 20:04 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.53 MB, application/zip)
2019-05-02 20:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews211 for win-future (13.98 MB, application/zip)
2019-05-02 22:22 PDT, Build Bot
no flags Details
Patch for Landing (12.51 KB, patch)
2019-05-03 12:06 PDT, Jiewen Tan
jiewen_tan: review?
jiewen_tan: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-05-02 18:49:48 PDT
A focused document should be required.
Comment 1 Radar WebKit Bug Importer 2019-05-02 18:50:35 PDT
<rdar://problem/50430989>
Comment 2 Radar WebKit Bug Importer 2019-05-02 18:51:43 PDT Comment hidden (obsolete)
Comment 3 Jiewen Tan 2019-05-02 19:03:00 PDT
Created attachment 368867 [details]
Patch
Comment 4 Brent Fulgham 2019-05-02 19:42:07 PDT
Comment on attachment 368867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171
> -    // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator.

Why are you removing this comment. At least we should say we aren't implementing these steps and why.

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-243
> -    if (!m_client)  {

Ditto.
Comment 5 Build Bot 2019-05-02 20:04:21 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2019-05-02 20:04:23 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2019-05-02 20:48:31 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2019-05-02 20:48:32 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2019-05-02 22:22:29 PDT Comment hidden (obsolete)
Comment 10 Build Bot 2019-05-02 22:22:33 PDT Comment hidden (obsolete)
Comment 11 Jiewen Tan 2019-05-03 11:04:53 PDT
Comment on attachment 368867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review

Thanks Brent for r+ this patch.

>> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171
>> -    // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator.
> 
> Why are you removing this comment. At least we should say we aren't implementing these steps and why.

Because all those steps are implemented.
Comment 12 Jiewen Tan 2019-05-03 12:06:10 PDT
Created attachment 368962 [details]
Patch for Landing
Comment 13 Jiewen Tan 2019-05-03 16:41:42 PDT
Committed r244938: <https://trac.webkit.org/changeset/244938>