Bug 197543 – [WebAuthN] A focused document should be required

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

A focused document should be required.

[Radar WebKit Bug Importer]

<rdar://problem/50430989>

[Radar WebKit Bug Importer]

<rdar://problem/50430987>

[Jiewen Tan]

Created attachment 368867 [details]
Patch

[Brent Fulgham]

Comment on attachment 368867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171
> -    // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator.

Why are you removing this comment. At least we should say we aren't implementing these steps and why.

> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-243
> -    if (!m_client)  {

Ditto.

[EWS Watchlist]

Comment on attachment 368867 [details]
Patch

Attachment 368867 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12073209

New failing tests:
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html

[EWS Watchlist]

Created attachment 368876 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 368867 [details]
Patch

Attachment 368867 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12073710

New failing tests:
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html

[EWS Watchlist]

Created attachment 368884 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.4

[EWS Watchlist]

Comment on attachment 368867 [details]
Patch

Attachment 368867 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12076757

New failing tests:
svg/repaint/remove-border-property-on-root.html
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 368896 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Jiewen Tan]

Comment on attachment 368867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review

Thanks Brent for r+ this patch.

>> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171
>> -    // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator.
> 
> Why are you removing this comment. At least we should say we aren't implementing these steps and why.

Because all those steps are implemented.

[Jiewen Tan]

Created attachment 368962 [details]
Patch for Landing

[Jiewen Tan]

Committed r244938: <https://trac.webkit.org/changeset/244938>