Bug 197540 - Need additional UIPreviewAction information in WKImagePreviewViewController
Summary: Need additional UIPreviewAction information in WKImagePreviewViewController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-02 18:31 PDT by Dean Jackson
Modified: 2019-05-03 12:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2019-05-02 18:34 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2019-05-02 19:01 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2019-05-02 19:02 PDT, Dean Jackson 		wenson_hsieh: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.76 MB, application/zip)
2019-05-02 20:01 PDT, EWS Watchlist 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-05-02 18:31:15 PDT 
Need additional UIPreviewAction information in WKImagePreviewViewController
Comment 1 Radar WebKit Bug Importer 2019-05-02 18:31:52 PDT 
<rdar://problem/50430510>
Comment 2 Dean Jackson 2019-05-02 18:34:51 PDT 
Created attachment 368863 [details]
Patch
Comment 3 Dean Jackson 2019-05-02 19:01:28 PDT 
Created attachment 368865 [details]
Patch
Comment 4 Dean Jackson 2019-05-02 19:02:35 PDT 
Created attachment 368866 [details]
Patch
Comment 5 EWS Watchlist 2019-05-02 20:01:34 PDT 
Comment on attachment 368866 [details]
Patch

Attachment 368866 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12073213

New failing tests:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
Comment 6 EWS Watchlist 2019-05-02 20:01:36 PDT 
Created attachment 368874 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 7 Wenson Hsieh 2019-05-02 22:00:13 PDT 
Comment on attachment 368866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368866&action=review

> Source/WebKit/UIProcess/WKImagePreviewViewController.mm:38
> +#define ADDITIONAL_PREVIEW_ACTION_ITEM_INFO

Nit - you might want to consider making this a method or function instead of a macro.
Comment 8 Dean Jackson 2019-05-03 12:35:28 PDT 
Committed r244916: <https://trac.webkit.org/changeset/244916>