Bug 197539 - Provide UIImages for element actions
Summary: Provide UIImages for element actions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-02 18:24 PDT by Dean Jackson
Modified: 2019-05-03 11:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.42 KB, patch)
2019-05-02 18:29 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2019-05-02 19:03 PDT, Dean Jackson 		wenson_hsieh: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (13.82 MB, application/zip)
2019-05-02 20:03 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-05-02 18:24:24 PDT 
Provide UIImages for element actions
Comment 1 Radar WebKit Bug Importer 2019-05-02 18:25:09 PDT 
<rdar://problem/50430363>
Comment 2 Dean Jackson 2019-05-02 18:29:07 PDT 
Created attachment 368861 [details]
Patch
Comment 3 Dean Jackson 2019-05-02 19:03:15 PDT 
Created attachment 368868 [details]
Patch
Comment 4 EWS Watchlist 2019-05-02 20:03:14 PDT 
Comment on attachment 368868 [details]
Patch

Attachment 368868 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12073262

New failing tests:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html
Comment 5 EWS Watchlist 2019-05-02 20:03:16 PDT 
Created attachment 368875 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Wenson Hsieh 2019-05-02 21:59:24 PDT 
Comment on attachment 368868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368868&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:30
> +#import <UIKit/UIImage.h>

Nit - I think you can get away with just @class UIImage;
Comment 7 Dean Jackson 2019-05-03 11:53:05 PDT 
Committed r244914: <https://trac.webkit.org/changeset/244914>