Bug 197531 – Don't OSR enter into an FTL CodeBlock that has been jettisoned

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

<rdar://problem/50162379>

[Saam Barati]

Created attachment 368824 [details]
patch

[EWS Watchlist]

Comment on attachment 368824 [details]
patch

Attachment 368824 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12067388

New failing tests:
legacy-animation-engine/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html

[EWS Watchlist]

Created attachment 368843 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Yusuke Suzuki]

Comment on attachment 368824 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368824&action=review

r=me

> Source/JavaScriptCore/ftl/FTLOSREntry.cpp:52
> +    if (!entryCode->dfgCommon()->isStillValid) {

I really want to clear the OSR entry block in the parent DFGCode when the OSR entry block is invalidated...
Can we do that thing?

[Saam Barati]

(In reply to Yusuke Suzuki from comment #5)
> Comment on attachment 368824 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368824&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ftl/FTLOSREntry.cpp:52
> > +    if (!entryCode->dfgCommon()->isStillValid) {
> 
> I really want to clear the OSR entry block in the parent DFGCode when the
> OSR entry block is invalidated...
> Can we do that thing?

Yeah I wanted to do that to. It seemed slightly awkward to do object model wise but let me look into it.

[Saam Barati]

Created attachment 368858 [details]
patch

[EWS Watchlist]

Comment on attachment 368858 [details]
patch

Attachment 368858 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12079225

New failing tests:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
svg/repaint/remove-border-property-on-root.html

[EWS Watchlist]

Created attachment 368908 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Saam Barati]

Yusuke and I spoke offline. We're going to go with the simpler, earlier version of this patch.

[Saam Barati]

Created attachment 369174 [details]
patch

[Saam Barati]

Created attachment 369176 [details]
patch for landing

[EWS Watchlist]

Comment on attachment 369176 [details]
patch for landing

Attachment 369176 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12122413

New failing tests:
http/tests/css/filters-on-iframes.html

[EWS Watchlist]

Created attachment 369275 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 369176 [details]
patch for landing

Clearing flags on attachment: 369176

Committed r245017: <https://trac.webkit.org/changeset/245017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.