Bug 197531 - Don't OSR enter into an FTL CodeBlock that has been jettisoned
Summary: Don't OSR enter into an FTL CodeBlock that has been jettisoned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-02 14:46 PDT by Saam Barati
Modified: 2019-05-07 10:41 PDT (History)
15 users (show)

See Also:

Attachments
patch (5.51 KB, patch)
2019-05-02 14:51 PDT, Saam Barati 		ysuzuki: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.63 MB, application/zip)
2019-05-02 16:35 PDT, EWS Watchlist 		no flags Details
patch (9.72 KB, patch)
2019-05-02 18:12 PDT, Saam Barati 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.90 MB, application/zip)
2019-05-03 00:21 PDT, EWS Watchlist 		no flags Details
patch (5.51 KB, patch)
2019-05-06 15:14 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (6.79 KB, patch)
2019-05-06 15:20 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (13.62 MB, application/zip)
2019-05-07 04:37 PDT, EWS Watchlist 		no flags Details
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-05-02 14:46:17 PDT 
...
Comment 1 Saam Barati 2019-05-02 14:46:53 PDT 
<rdar://problem/50162379>
Comment 2 Saam Barati 2019-05-02 14:51:00 PDT 
Created attachment 368824 [details]
patch
Comment 3 EWS Watchlist 2019-05-02 16:35:52 PDT 
Comment on attachment 368824 [details]
patch

Attachment 368824 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12067388

New failing tests:
legacy-animation-engine/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
Comment 4 EWS Watchlist 2019-05-02 16:35:53 PDT 
Created attachment 368843 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Yusuke Suzuki 2019-05-02 16:42:22 PDT 
Comment on attachment 368824 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368824&action=review

r=me

> Source/JavaScriptCore/ftl/FTLOSREntry.cpp:52
> +    if (!entryCode->dfgCommon()->isStillValid) {

I really want to clear the OSR entry block in the parent DFGCode when the OSR entry block is invalidated...
Can we do that thing?
Comment 6 Saam Barati 2019-05-02 17:13:57 PDT 
(In reply to Yusuke Suzuki from comment #5)
> Comment on attachment 368824 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368824&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ftl/FTLOSREntry.cpp:52
> > +    if (!entryCode->dfgCommon()->isStillValid) {
> 
> I really want to clear the OSR entry block in the parent DFGCode when the
> OSR entry block is invalidated...
> Can we do that thing?

Yeah I wanted to do that to. It seemed slightly awkward to do object model wise but let me look into it.
Comment 7 Saam Barati 2019-05-02 18:12:47 PDT 
Created attachment 368858 [details]
patch
Comment 8 EWS Watchlist 2019-05-03 00:21:06 PDT 
Comment on attachment 368858 [details]
patch

Attachment 368858 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12079225

New failing tests:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
svg/repaint/remove-border-property-on-root.html
Comment 9 EWS Watchlist 2019-05-03 00:21:08 PDT 
Created attachment 368908 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 10 Saam Barati 2019-05-06 15:12:42 PDT 
Yusuke and I spoke offline. We're going to go with the simpler, earlier version of this patch.
Comment 11 Saam Barati 2019-05-06 15:14:18 PDT 
Created attachment 369174 [details]
patch
Comment 12 Saam Barati 2019-05-06 15:20:27 PDT 
Created attachment 369176 [details]
patch for landing
Comment 13 EWS Watchlist 2019-05-07 04:37:36 PDT 
Comment on attachment 369176 [details]
patch for landing

Attachment 369176 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12122413

New failing tests:
http/tests/css/filters-on-iframes.html
Comment 14 EWS Watchlist 2019-05-07 04:37:38 PDT 
Created attachment 369275 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 15 WebKit Commit Bot 2019-05-07 10:41:49 PDT 
Comment on attachment 369176 [details]
patch for landing

Clearing flags on attachment: 369176

Committed r245017: <https://trac.webkit.org/changeset/245017>
Comment 16 WebKit Commit Bot 2019-05-07 10:41:51 PDT 
All reviewed patches have been landed.  Closing bug.