Bug 197507 - [GTK] Lots of flaky tests happening after r244182 "requestAnimationFrame should execute before the next frame"
Summary: [GTK] Lots of flaky tests happening after r244182 "requestAnimationFrame shou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-02 07:51 PDT by Miguel Gomez
Modified: 2023-01-25 19:37 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-05-02 07:51:38 PDT
fast/css/transition-color-unspecified.html [ Timeout Pass ]

This is pretty suspicious, as it always times out on the first run since r244182, but there's no info about why.
Comment 1 Miguel Gomez 2019-05-02 07:52:16 PDT
Said, do you have any clue about how can r244182 be affecting this?
Comment 2 Miguel Gomez 2019-05-02 08:08:49 PDT
This test made me suspicious of r244182 as the reason of many tests that started timing out on the first run. I've rechecked and I found several other tests started failing on that revision or close ones. Also, these tests have in common that they don't have any output: no diff, no stderr, nothing, just a timeout.

compositing/updates/animation-non-composited.html [ Timeout Pass ]
css3/filters/blur-various-radii.html [ Timeout Pass ]
fast/block/block-move-frequent-paint.html [ Timeout Pass ]
fast/css-generated-content/pseudo-element-events.html [ Timeout Pass ]
fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html [ Timeout Pass ]
fast/css/transition-color-unspecified.html [ Timeout Pass ]
fast/images/animated-gif-iframe-webkit-transform.html [ Timeout Pass ]
fast/scrolling/momentum-scroll-with-borders.html [ Timeout Pass ]
imported/blink/compositing/repaint/end-of-opacity-transition.html [ Timeout Pass ]
imported/blink/css3/calc/transition-asan-crash.html [ Timeout Pass ]
imported/blink/svg/hittest/rect-miterlimit.html [ Timeout Pass ]
imported/blink/transitions/no-transition-on-implicit-margins.html [ Timeout Pass ]
imported/mozilla/css-animations/test_animation-cancel.html [ Timeout Pass ]
imported/mozilla/css-transitions/test_animation-cancel.html [ Timeout Pass ]
inspector/canvas/recording-2d.html [ Failure Timeout ]
legacy-animation-engine/animations/animation-multiple-callbacks-timestamp.html [ Timeout Pass ]
legacy-animation-engine/imported/blink/css3/calc/transition-asan-crash.html [ Timeout Pass ]
media/destructor-logging-crash.html [ Timeout Pass ]
Comment 3 Miguel Gomez 2019-05-02 08:15:32 PDT
This could also be related to the flaky tests I reported on https://bugs.webkit.org/show_bug.cgi?id=197497 and  https://bugs.webkit.org/show_bug.cgi?id=197498. On a second look I found that they started failing after r244182 as well. At least there are some diffs in those tests that can shed some light to the issue, but the summary is that they are timing out as well.

Said, do you see any pattern here? Any clues about where to look for the problem?
Comment 4 Diego Pino 2020-03-01 10:31:47 PST
Another related tests:

  * legacy-animation-engine/animations/animation-iteration-event-destroy-renderer.html [ Timeout Pass ]

First flaky at:

r244271                       NOERROR
[r244272-r244284]             UNKNOWN
r244285                       TIMEOUT PASS (Expected: PASS)
Comment 5 Diego Pino 2023-01-25 19:37:13 PST
There are no references to this bug in any TestExpectations. It's probable this bug was solved at some point but it wasn't marked as closed. I'm closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations.