Bug 19749 - Merge inc/dec halves of PrefixBracketNode and PostfixBracketNode
Summary: Merge inc/dec halves of PrefixBracketNode and PostfixBracketNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-24 09:14 PDT by Gavin Barraclough
Modified: 2008-07-17 04:48 PDT (History)
0 users

See Also:

Attachments
Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode (9.74 KB, patch)
2008-06-24 09:15 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
updated (10.41 KB, patch)
2008-07-16 17:50 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-06-24 09:14:28 PDT 
Post Squirrelfish there is no longer a performance gain in having separate nodes for inc and dec – merging these will simplify & reduce code duplication in the parse tree.

Patch following.
Comment 1 Gavin Barraclough 2008-06-24 09:15:12 PDT 
Created attachment 21907 [details]
Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode
Comment 2 Sam Weinig 2008-06-24 20:37:55 PDT 
Comment on attachment 21907 [details]
Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode

Nice job! r=me.
Comment 3 Gavin Barraclough 2008-07-16 17:50:38 PDT 
Created attachment 22326 [details]
updated

Enough of a conflict I thought I should put a new patch up.
Comment 4 Gavin Barraclough 2008-07-17 04:47:55 PDT 
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/kjs/grammar.y
Sending        JavaScriptCore/kjs/nodes.cpp
Sending        JavaScriptCore/kjs/nodes.h
Sending        JavaScriptCore/kjs/nodes2string.cpp
Transmitting file data .....
Committed revision 35218.