Bug 197483 - [PlayStation] Update port for WEBKIT_EXECUTABLE changes
Summary: [PlayStation] Update port for WEBKIT_EXECUTABLE changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-01 16:03 PDT by Stephan Szabo
Modified: 2019-05-01 17:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2019-05-01 16:08 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2019-05-01 16:03:09 PDT 
PlayStation was wrapping add_executable for doing some setup and signing, but this usage does not function as expected after the WEBKIT_EXECUTABLE changes and the timing change of when add_executable is called.
Comment 1 Stephan Szabo 2019-05-01 16:08:25 PDT 
Created attachment 368728 [details]
Patch

Move to wrapping the new WEBKIT_EXECUTABLE macro rather than add_executable for post-port-configuration executable setup.
Comment 2 WebKit Commit Bot 2019-05-01 17:09:55 PDT 
Comment on attachment 368728 [details]
Patch

Clearing flags on attachment: 368728

Committed r244859: <https://trac.webkit.org/changeset/244859>
Comment 3 WebKit Commit Bot 2019-05-01 17:09:57 PDT 
All reviewed patches have been landed.  Closing bug.