Bug 197470 - Web Inspector: Audit: make it easier to jump to any returned DOM node in the Elements tab
Summary: Web Inspector: Audit: make it easier to jump to any returned DOM node in the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: WebInspectorAuditTab
Blocks:
  Show dependency tree / graph
 
Reported: 2019-05-01 12:23 PDT by Devin Rousso
Modified: 2019-05-17 22:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.65 KB, patch)
2019-05-03 22:13 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2019-05-03 22:17 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (Inline) (765.35 KB, image/png)
2019-05-17 21:18 PDT, Devin Rousso 		no flags Details
[Image] After Patch is applied (Expanded) (913.03 KB, image/png)
2019-05-17 21:18 PDT, Devin Rousso 		no flags Details
Patch (11.40 KB, patch)
2019-05-17 21:22 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-05-01 12:23:16 PDT 
When returning DOM nodes via `domNodes`, there's no "obvious" way (there's a context menu option) to jump to the live location of that DOM node in the DOM tree (e.g. in the Elements tab).
Comment 1 Devin Rousso 2019-05-03 22:13:49 PDT 
Created attachment 369050 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-05-03 22:14:00 PDT 
<rdar://problem/50466773>
Comment 3 Radar WebKit Bug Importer 2019-05-03 22:14:00 PDT 
<rdar://problem/50466774>
Comment 4 Devin Rousso 2019-05-03 22:17:45 PDT 
Created attachment 369052 [details]
Patch

Split `WI.TreeElement` fix into a separate bug 197591.
Comment 5 Joseph Pecoraro 2019-05-17 16:12:25 PDT 
Comment on attachment 369052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369052&action=review

r=me

> Source/WebInspectorUI/ChangeLog:18
> +        Provide a way to insert a go-to arrow right after the:

Should include a screenshot of what this looks like to make review easier.
Comment 6 Devin Rousso 2019-05-17 21:18:19 PDT 
Created attachment 370180 [details]
[Image] After Patch is applied (Inline)
Comment 7 Devin Rousso 2019-05-17 21:18:40 PDT 
Created attachment 370181 [details]
[Image] After Patch is applied (Expanded)
Comment 8 Devin Rousso 2019-05-17 21:22:00 PDT 
Created attachment 370182 [details]
Patch
Comment 9 WebKit Commit Bot 2019-05-17 22:10:35 PDT 
Comment on attachment 370182 [details]
Patch

Clearing flags on attachment: 370182

Committed r245497: <https://trac.webkit.org/changeset/245497>
Comment 10 WebKit Commit Bot 2019-05-17 22:10:37 PDT 
All reviewed patches have been landed.  Closing bug.