Bug 19747 – Merge inc/dec halves of PrefixDotNode and PostfixDotNode

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Post Squirrelfish there is no longer a performance gain in having separate nodes for inc and dec – merging these will simplify & reduce code duplication in the parse tree.

Patch following.

[Gavin Barraclough]

Created attachment 21906 [details]
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode

[Sam Weinig]

Comment on attachment 21906 [details]
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode

Nice job!  A couple of nits on style.

Some white space issue here.
+        virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) KJS_FAST_CALL;
+       virtual void streamTo(SourceStream&) const KJS_FAST_CALL;

Here too.      
+       Operator m_operator;
+     };

r=me if you fix those issues.

[Gavin Barraclough]

Created attachment 21928 [details]
Eeep! - fix for whitespace error.

[Sam Weinig]

Comment on attachment 21928 [details]
Eeep! - fix for whitespace error.

Very nice!

[Gavin Barraclough]

Created attachment 22323 [details]
merged up for commit

Enough of a conflict I thought I should put a new patch up.

[Gavin Barraclough]

Created attachment 22328 [details]
fix to the update

[Gavin Barraclough]

Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/kjs/grammar.y
Sending        JavaScriptCore/kjs/nodes.cpp
Sending        JavaScriptCore/kjs/nodes.h
Sending        JavaScriptCore/kjs/nodes2string.cpp
Transmitting file data .....
Committed revision 35224.