Bug 19747 - Merge inc/dec halves of PrefixDotNode and PostfixDotNode
Summary: Merge inc/dec halves of PrefixDotNode and PostfixDotNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-24 08:56 PDT by Gavin Barraclough
Modified: 2008-07-17 12:35 PDT (History)
0 users

See Also:

Attachments
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode (9.01 KB, patch)
2008-06-24 08:57 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
Eeep! - fix for whitespace error. (8.99 KB, patch)
2008-06-25 08:06 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
merged up for commit (6.60 KB, patch)
2008-07-16 17:31 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
fix to the update (9.73 KB, patch)
2008-07-16 19:26 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-06-24 08:56:00 PDT 
Post Squirrelfish there is no longer a performance gain in having separate nodes for inc and dec – merging these will simplify & reduce code duplication in the parse tree.

Patch following.
Comment 1 Gavin Barraclough 2008-06-24 08:57:40 PDT 
Created attachment 21906 [details]
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode
Comment 2 Sam Weinig 2008-06-24 20:35:42 PDT 
Comment on attachment 21906 [details]
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode

Nice job!  A couple of nits on style.

Some white space issue here.
+        virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) KJS_FAST_CALL;
+       virtual void streamTo(SourceStream&) const KJS_FAST_CALL;

Here too.      
+       Operator m_operator;
+     };

r=me if you fix those issues.
Comment 3 Gavin Barraclough 2008-06-25 08:06:40 PDT 
Created attachment 21928 [details]
Eeep! - fix for whitespace error.
Comment 4 Sam Weinig 2008-06-25 10:29:01 PDT 
Comment on attachment 21928 [details]
Eeep! - fix for whitespace error.

Very nice!
Comment 5 Gavin Barraclough 2008-07-16 17:31:43 PDT 
Created attachment 22323 [details]
merged up for commit

Enough of a conflict I thought I should put a new patch up.
Comment 6 Gavin Barraclough 2008-07-16 19:26:10 PDT 
Created attachment 22328 [details]
fix to the update
Comment 7 Gavin Barraclough 2008-07-17 12:35:18 PDT 
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/kjs/grammar.y
Sending        JavaScriptCore/kjs/nodes.cpp
Sending        JavaScriptCore/kjs/nodes.h
Sending        JavaScriptCore/kjs/nodes2string.cpp
Transmitting file data .....
Committed revision 35224.