Bug 197469 - [iOS] Star rating is covered with a black circle when writing a review on Yelp
Summary: [iOS] Star rating is covered with a black circle when writing a review on Yelp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-01 11:58 PDT by zalan
Modified: 2019-05-01 16:09 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.52 KB, patch)
2019-05-01 13:13 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-05-01 11:58:29 PDT
<rdar://problem/48094446>
Comment 1 zalan 2019-05-01 13:13:12 PDT
Created attachment 368695 [details]
Patch
Comment 2 zalan 2019-05-01 13:14:34 PDT
This might just be temp if we decide to move more style painting from RenderTheme to html.css after resolving the "where is this style coming from" question to support -webkit-appearance: none.
Comment 3 WebKit Commit Bot 2019-05-01 13:46:25 PDT
Comment on attachment 368695 [details]
Patch

Clearing flags on attachment: 368695

Committed r244848: <https://trac.webkit.org/changeset/244848>
Comment 4 WebKit Commit Bot 2019-05-01 13:46:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2019-05-01 15:25:58 PDT
This change caused layout test failures on iOS simulator. It looks like EWS caught the failures, but it didn't finish verifying results.

Regressions: Unexpected text-only failures (4)
  compositing/overflow/theme-affects-visual-overflow.html [ Failure ]
  fast/block/margin-collapse/103.html [ Failure ]
  fast/parser/bad-xml-slash.html [ Failure ]
  tables/mozilla/bugs/bug4527.html [ Failure ]

https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r244848%20(3881)/results.html
Comment 6 zalan 2019-05-01 15:38:45 PDT
(In reply to Ryan Haddad from comment #5)
> This change caused layout test failures on iOS simulator. It looks like EWS
> caught the failures, but it didn't finish verifying results.
> 
> Regressions: Unexpected text-only failures (4)
>   compositing/overflow/theme-affects-visual-overflow.html [ Failure ]
>   fast/block/margin-collapse/103.html [ Failure ]
>   fast/parser/bad-xml-slash.html [ Failure ]
>   tables/mozilla/bugs/bug4527.html [ Failure ]
> 
> https://build.webkit.org/results/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r244848%20(3881)/
> results.html
Thanks, will rebaseline them.
Comment 7 zalan 2019-05-01 16:09:20 PDT
https://trac.webkit.org/changeset/244855/webkit should take care of them.