Bug 197464 – Cache.add and Cache.addAll should compute a correct response body size

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Cache.add and Cache.addAll should compute a correct response body size

[youenn fablet]

Created attachment 368676 [details]
Patch

[youenn fablet]

Created attachment 368730 [details]
Patch

[Chris Dumez]

Comment on attachment 368730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368730&action=review

> Source/WebCore/Modules/cache/DOMCache.cpp:179
> +        DOMCacheEngine::ResponseBody body = WTFMove(data);

Does not seem like we need this local variable.

> Source/WebCore/Modules/cache/DOMCache.cpp:180
> +        record.responseBodySize = m_domCache->connection().computeRecordBodySize(response, body);

s/body/data

> Source/WebCore/Modules/cache/DOMCache.cpp:181
> +        record.responseBody = WTFMove(body);

s/body/data

> Source/WebCore/Modules/cache/DOMCache.cpp:237
> +    auto taskHandler = FetchTasksHandler::create(makeRef(*this), [this, promise = WTFMove(promise)](ExceptionOr<Vector<Record>>&& result) mutable {

s/makeRef(*this)/*this

[youenn fablet]

Created attachment 368953 [details]
Patch for landing

[EWS Watchlist]

Comment on attachment 368953 [details]
Patch for landing

Attachment 368953 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12090360

New failing tests:
svg/repaint/add-background-property-on-root.html
svg/repaint/remove-background-property-on-root.html
svg/repaint/remove-border-property-on-root.html
svg/repaint/change-background-color.html
svg/repaint/add-border-property-on-root.html

[EWS Watchlist]

Created attachment 368970 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[youenn fablet]

Win error unrelated

[WebKit Commit Bot]

Comment on attachment 368953 [details]
Patch for landing

Clearing flags on attachment: 368953

Committed r244918: <https://trac.webkit.org/changeset/244918>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50455076>