Bug 197451 - REGRESSION (r244182): RenderingUpdate should not be scheduled for invisible pages
Summary: REGRESSION (r244182): RenderingUpdate should not be scheduled for invisible p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-30 18:18 PDT by Said Abou-Hallawa
Modified: 2019-05-01 12:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.40 KB, patch)
2019-04-30 18:28 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (6.61 KB, patch)
2019-05-01 10:26 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-04-30 18:18:54 PDT
Safari creates a blank web page when it is opened. This page will not be visible unless the user selects to open new tabs with "Empty page". The loader of this page forces Document::resolveStyle() which requires RenderLayerCompositor::scheduleLayerFlushNow().

Before r244182, this would just call scheduleCompositingLayerFlush() immediately. After r244182, RenderLayerCompositor::scheduleLayerFlushNow() has to schedule a RenderingUpdate and when it fires it calls scheduleCompositingLayerFlush().

We need to optimize this case by checking whether the page is visible or not before scheduling the RenderingUpdate.
Comment 1 Said Abou-Hallawa 2019-04-30 18:28:49 PDT
Created attachment 368642 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-05-01 10:26:39 PDT
Created attachment 368684 [details]
Patch
Comment 3 Said Abou-Hallawa 2019-05-01 10:30:05 PDT
<rdar://problem/50224329>
Comment 4 WebKit Commit Bot 2019-05-01 12:31:11 PDT
Comment on attachment 368684 [details]
Patch

Clearing flags on attachment: 368684

Committed r244837: <https://trac.webkit.org/changeset/244837>
Comment 5 WebKit Commit Bot 2019-05-01 12:31:13 PDT
All reviewed patches have been landed.  Closing bug.