Bug 197443 - Safe browsing warning should update colors when a user switches between light and dark appearance
Summary: Safe browsing warning should update colors when a user switches between light...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-30 16:33 PDT by Alex Christensen
Modified: 2019-05-02 10:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.45 KB, patch)
2019-04-30 16:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.90 KB, patch)
2019-04-30 16:42 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.92 KB, patch)
2019-04-30 17:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.99 KB, patch)
2019-05-01 16:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-30 16:33:51 PDT 
Safe browsing warning should update colors when a user switches between light and dark appearance
Comment 1 Alex Christensen 2019-04-30 16:34:18 PDT 
Created attachment 368626 [details]
Patch
Comment 2 Alex Christensen 2019-04-30 16:42:11 PDT 
Created attachment 368630 [details]
Patch
Comment 3 Tim Horton 2019-04-30 17:09:28 PDT 
Comment on attachment 368630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368630&action=review

> Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:200
>  

This should be inside a PLATFORM(MAC)
Comment 4 Alex Christensen 2019-04-30 17:34:51 PDT 
Created attachment 368634 [details]
Patch
Comment 5 Alex Christensen 2019-05-01 16:24:56 PDT 
Created attachment 368731 [details]
Patch
Comment 6 Alex Christensen 2019-05-02 10:38:19 PDT 
http://trac.webkit.org/r244875