Bug 19743 – Release build fails on 32-bit Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

As of a few weeks ago, it seems to be impossible to successfully build WebKit in the Release configuration on Windows XP. Vista machines (and one Server 2003 R2 machine) build fine. Errors like this occur when linking:

> Creating library...
> d:\WebKit-BuildSlave\trunk-win-release\build\WebKitBuild\lib\WebCore.lib : fatal error LNK1106: invalid file or disk full: cannot seek to 0x51D16DEE

This seems to be due to whole-program optimization (WPO). My guess is that we're running out of virtual address space.

I don't know why this affects XP but not Vista -- perhaps there was a bug in the OS that was fixed.

Booting with the /3GB option does not fix the issue.

This is affecting the build bots.

[Adam Roben (:aroben)]

This appears to be affecting Vista now as well.

[Adam Roben (:aroben)]

http://support.microsoft.com/kb/888326 has some potentially-relevant information.

[Mark Rowe (bdash)]

<rdar://problem/6094248>

[Eric Seidel (no email)]

Mark Rowe was updating me on the status yesterday in #webkit.

This is an approximate summary of what he said:

It seems to be a bug which we tickle in MSVC because of our usage of
templates in SVGAnimatedProperty.h.  Including SVGAnimatedProperty.h
increases the object file size by a MB (which is the bug), and since
SVGStyledElement.h includes it, anything which touches SVG in the
codebase ends up with at least a 1MB object file.  Boom.  Linker
fails.

The Applers are working on a fix yet.

[Adam Roben (:aroben)]

Fixed in r35629

[Adam Roben (:aroben)]

This has started happening again.

[Ben Murdoch]

Created attachment 29173 [details]
Combines html element cpp files into one whic helps reduce the size of webcore.lib

[Adam Roben (:aroben)]

Comment on attachment 29173 [details]
Combines html element cpp files into one whic helps reduce the size of webcore.lib

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 42150)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,21 @@
> [phone]  Ben Murdoch  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Combines all the HTML element cpp files into one to help reduce the size of WebCore.lib so we can build in release mode on 32bit Windows.
> +
> +        * WebCore.vcproj/WebCore.vcproj:
> +        * html/HTMLElements.cpp: Added.
> +
> [phone]  Ben Murdoch  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Reduce the size of WebCore.lib so we can continue building release mode on 32 bit Windows.
> +
> +        * WebCore.vcproj/WebCore.vcproj:
> +        * html/HTMLElements.cpp: Added.
> +

You have two ChangeLog entries here. It would be good to mention this bug in your ChangeLog entry.

> @@ -12638,103 +12638,51 @@
>  				>
>  			</File>
>  			<File
> -				RelativePath="..\html\HTMLAnchorElement.cpp"
> -				>
> -				<FileConfiguration
> -					Name="Release_PGO|Win32"
> -					>
> -					<Tool
> -						Name="VCCLCompilerTool"
> -						WholeProgramOptimization="true"
> -					/>
> -				</FileConfiguration>
> -			</File>
> -			<File

I think rather than removing the .cpp files from the project entirely (as was unfortunately done for SVG), it would be better to use the "Excluded From Build" option (right-click on the file, go to Configuration Properties > General). That way the .cpp files will still be accessible from the Solution Explorer. Eventually we should put the SVG .cpp files back into the .vcproj using this method.

> Property changes on: WebCore/html/HTMLElements.cpp
> ___________________________________________________________________
> Added: svn:executable
>    + *

You should remove this property. We also normally set svn:eol-style to native for new files.

Maybe the new file should have "AllInOne" in its name? That would match JavaScriptCore's AllInOneFile.cpp and SVGAllInOne.cpp.

r- for now, but I don't think it will be much work to get this commitable!

[Ben Murdoch]

Created attachment 29177 [details]
v2: Combines html element cpp files into one which helps reduce the size of webcore.lib

[Adam Roben (:aroben)]

Comment on attachment 29177 [details]
v2: Combines html element cpp files into one which helps reduce the size of webcore.lib

r=me

[Adam Roben (:aroben)]

Landed as r42175

[Arunprasad]

I would like to know one additional info. Sorry in-case I'm wrong.

Actually this template bloat only increases the static library size or it will increase the runtime executable size as well?