Bug 197428 – XMLHttpRequest should propagate user gestures for media playback

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

XMLHttpRequest should propagate user gestures for media playback.

[Eric Carlson]

<rdar://problem/46677392>

[Eric Carlson]

Created attachment 368599 [details]
Patch

[EWS Watchlist]

Comment on attachment 368599 [details]
Patch

Attachment 368599 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12044080

New failing tests:
fast/events/popup-blocking-timers5.html

[EWS Watchlist]

Created attachment 368612 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 368599 [details]
Patch

Attachment 368599 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12044204

New failing tests:
fast/events/popup-blocking-timers5.html

[EWS Watchlist]

Created attachment 368613 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Eric Carlson]

Created attachment 368614 [details]
Patch

[Jer Noble]

Comment on attachment 368614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368614&action=review

> Source/WebCore/xml/XMLHttpRequest.cpp:69
> +static const Seconds maximumIntervalForUserGestureForwarding { 10_s };

Nit: I think it's really weird that there's both `maxIntervalForUserGestureForwarding` in DOMTimer and `maximumIntervalForUserGestureForwarding` in XMLHttpRequest, and that they're different values. (1s vs. 10s.)

Doesn't this mean that a xhr -> timer -> xhr of less that 10s will break if the first xhr takes > 1s?

[Eric Carlson]

Comment on attachment 368614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368614&action=review

Thanks for the review!

>> Source/WebCore/xml/XMLHttpRequest.cpp:69
>> +static const Seconds maximumIntervalForUserGestureForwarding { 10_s };
> 
> Nit: I think it's really weird that there's both `maxIntervalForUserGestureForwarding` in DOMTimer and `maximumIntervalForUserGestureForwarding` in XMLHttpRequest, and that they're different values. (1s vs. 10s.)
> 
> Doesn't this mean that a xhr -> timer -> xhr of less that 10s will break if the first xhr takes > 1s?

No, because XMLHttpRequest and DOMTimer both set a RefPtr<UserGestureIndicator> instance variable to null when their local timeout expires.

[WebKit Commit Bot]

Comment on attachment 368614 [details]
Patch

Clearing flags on attachment: 368614

Committed r244823: <https://trac.webkit.org/changeset/244823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.