Bug 197427 – font-weight: 1000 is not parsed successfully

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

font-weight: 1000 is not parsed successfully

[Myles C. Maxfield]

Created attachment 368586 [details]
Patch

[Dean Jackson]

Comment on attachment 368586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368586&action=review

> LayoutTests/fast/text/font-weight-1-1000.html:16
> +let reference = window.getComputedStyle(document.getElementById("reference")).getPropertyValue("font-weight");

Super super super nit: const :)

[Jon Lee]

Comment on attachment 368586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368586&action=review

> LayoutTests/fast/text/font-weight-1-1000-expected.txt:11
> +PASS window.getComputedStyle(document.getElementById('test6')).getPropertyValue('font-weight') is "1000"

not the other side of the <= comparison? 1000.5, 1001?

[EWS Watchlist]

Comment on attachment 368586 [details]
Patch

Attachment 368586 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12043597

New failing tests:
http/tests/security/window-events-clear-port.html
webaudio/up-mixing-stereo-51.html

[EWS Watchlist]

Created attachment 368607 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 368586 [details]
Patch

Attachment 368586 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12043871

New failing tests:
fast/text/font-weight-1-1000.html

[EWS Watchlist]

Created attachment 368609 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Myles C. Maxfield]

Committed r244817: <https://trac.webkit.org/changeset/244817>

[Radar WebKit Bug Importer]

<rdar://problem/50358084>