Bug 197423 – [ews-build] Parse and display bindings test failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Bindings tests queue should parse the test failures from the json output, and include that information in step and build status.

[Aakash Jain]

Created attachment 368578 [details]
Patch

[Aakash Jain]

Sample runs: 
Patch with bindings test failures: https://ews-build.webkit-uat.org/#/builders/21/builds/4802
Patch without bindings test failures: https://ews-build.webkit-uat.org/#/builders/21/builds/4801

[Lucas Forschler]

Comment on attachment 368578 [details]
Patch

lgtm... I'm curious about the timeout. how long do these normally take to run?

[Aakash Jain]

> lgtm... I'm curious about the timeout. how long do these normally take to run?
Usually takes a minute or two to run. Timeout is for the amount of time without any output, in case the script/machine is hanging/slow for any reason.

[EWS Watchlist]

Attachment 368578 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:470:  [RunBindingsTests.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:478:  [RunBindingsTests.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:478:  [RunBindingsTests.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:479:  [RunBindingsTests.getResultSummary] Instance of 'RunBindingsTests' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:303:  [TestRunBindingsTests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:303:  [TestRunBindingsTests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 368578 [details]
Patch

Clearing flags on attachment: 368578

Committed r244789: <https://trac.webkit.org/changeset/244789>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50343367>