Bug 19739 - REGRESSION: fast/js/property-getters-and-setters.html fails
Summary: REGRESSION: fast/js/property-getters-and-setters.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Darin Adler
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2008-06-24 00:44 PDT by Cameron Zwarich (cpst)
Modified: 2008-06-24 13:00 PDT (History)
4 users (show)

See Also:


Attachments
patch (1.93 KB, patch)
2008-06-24 08:43 PDT, Darin Adler
zwarich: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-06-24 00:44:44 PDT
The layout test fast/js/property-getters-and-setters.html now fails. All tests were passing for me with  r34751, so I suspect that r34754 is to blame. I'll go from r34753 to r34754 soon to double check, but going back and forth requires rebuilding the entire world due to the scope of the changes.
Comment 1 Darin Adler 2008-06-24 08:29:17 PDT
That's strange. I had run all the regression tests with my changes. Maybe I made a tweak after the fact that broke this. I'll look at this ASAP.
Comment 2 Darin Adler 2008-06-24 08:43:58 PDT
Created attachment 21905 [details]
patch
Comment 3 Darin Adler 2008-06-24 08:44:14 PDT
Sorry, it *was* something I tweaked after running all the tests.
Comment 4 Cameron Zwarich (cpst) 2008-06-24 10:50:47 PDT
Comment on attachment 21905 [details]
patch

r=me
Comment 5 Darin Adler 2008-06-24 13:00:59 PDT
Committed revision 34773.